Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a conversion from &mut T to &mut UnsafeCell<T> #111654

Merged
merged 1 commit into from
May 17, 2023
Merged

Add a conversion from &mut T to &mut UnsafeCell<T> #111654

merged 1 commit into from
May 17, 2023

Conversation

JoJoJet
Copy link
Contributor

@JoJoJet JoJoJet commented May 16, 2023

Provides a safe way of downgrading an exclusive reference into an alias-able &UnsafeCell<T> reference.

ACP: rust-lang/libs-team#198.

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@JoJoJet JoJoJet mentioned this pull request May 16, 2023
Open
4 tasks
@JoJoJet
Copy link
Contributor Author

JoJoJet commented May 16, 2023

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2023
@clubby789
Copy link
Contributor

@bors r=joshtriplett

#107917 (comment)

@bors
Copy link
Contributor

bors commented May 16, 2023

📌 Commit ffacb88 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request May 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
@bors
Auto merge of rust-lang#111671 - Dylan-DPC:rollup-1jy5r16, r=Dylan-DPC
c2ccc85 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110145 (Share slice of bytes)
 - rust-lang#111043 (Stabilize feature `cstr_is_empty`)
 - rust-lang#111648 (Remove `LangItems::require`)
 - rust-lang#111649 (Add derive for `core::marker::ConstParamTy`)
 - rust-lang#111654 (Add a conversion from `&mut T` to `&mut UnsafeCell<T>`)
 - rust-lang#111661 (Erase regions of type in `offset_of!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 71fdb95 into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
@JoJoJet JoJoJet deleted the unsafe-cell-from-mut-lib branch May 17, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JoJoJet @rustbot @clubby789 @bors @thomcc