-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: don't suggest MaybeUninit::assume_init for uninhabited types #108000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 13, 2023
r=me with rebase |
jackh726
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 18, 2023
☔ The latest upstream changes (presumably #108211) made this pull request unmergeable. Please resolve the merge conflicts. |
y21
force-pushed
the
no-zero-init-for-uninhabited
branch
from
February 18, 2023 18:07
aa4d748
to
0610df9
Compare
Rebased and squashed the commits into one |
@jackh726, is there anything else I need to do here? Just making sure so it doesn't get lost or run into merge conflicts again. |
Nope @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 20, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#108000 (lint: don't suggest MaybeUninit::assume_init for uninhabited types) - rust-lang#108105 (Explain the default panic hook better) - rust-lang#108141 (Add rpitit queries) - rust-lang#108272 (docs: wrong naming convention in struct keyword doc) - rust-lang#108285 (remove unstable `pick_stable_methods_before_any_unstable` flag) - rust-lang#108289 (Name placeholder in some region errors) - rust-lang#108290 (Add a test for default trait method with RPITITs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a zeroed uninhabited type such as
!
or an empty enum withmem::zeroed()
(or transmuting()
to!
) currently triggers this lint:The
MaybeUninit
suggestion in the help message seems confusing/useless for uninhabited types, as such a type cannot be fully initialized in the first place (as the note implies).This PR limits this help message to inhabited types which can be initialized