Assert if inference vars are leaking from InferCtxt::fully_resolve
#102903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
compiler-errors
commented
Oct 10, 2022
| @@ -1,4 +1,6 @@ | |||
| // check-pass | |||
| // known-bug: unknown | |||
There was a problem hiding this comment.
This is a bug on my end, but I should fix it independently.
dce8675
to
2f14465
Compare
|
Does this need to be rebased? r=me |
2f14465
to
1727c00
Compare
|
@bors r=jackh726 rollup=never |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (6365e5a): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Nov 22, 2022
…pty-hack, r=TaKO8Ki Remove a lifetime resolution hack from `compare_predicate_entailment` This is not needed anymore, probably due to rust-lang#102334 equating the function signatures fully in `collect_trait_impl_trait_tys`. Also, the assertion in in rust-lang#102903 makes sure that this is actually fixed, so I'm pretty confident this isn't needed.
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…ackh726 Assert if inference vars are leaking from `InferCtxt::fully_resolve` `InferCtxt::fully_resolve` shouldn't return unresolved inference vars without us at least being aware of it, so make it an assertion now. This should only happen in cases where we used to be returning `ReEmpty`... cc `@jackh726`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InferCtxt::fully_resolveshouldn't return unresolved inference vars without us at least being aware of it, so make it an assertion now. This should only happen in cases where we used to be returningReEmpty...cc @jackh726