Fix associated type bindings with anon const in GAT position #102336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @spastorino (rust-highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #102306) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Nominating for beta backport so it can ride the train with GATs stabilization. |
4fc892d
to
92561f4
Compare
|
Compared to the other PR I put up that's beta-nominated, this one is less urgent (and harder to backport I think) since it ICEs, and doesn't compile successfully. |
|
r? @jackh726 |
|
@bors r+ |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 28, 2022
…ckh726 Fix associated type bindings with anon const in GAT position The first commit formats `type_of.rs`, which is really hard to maintain since it uses a bunch of features like `let`-chains and `if let` match arm bindings. Best if you just review the second two diffs. Fixes rust-lang#102333
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 28, 2022
…ckh726 Fix associated type bindings with anon const in GAT position The first commit formats `type_of.rs`, which is really hard to maintain since it uses a bunch of features like `let`-chains and `if let` match arm bindings. Best if you just review the second two diffs. Fixes rust-lang#102333
This was referenced Sep 28, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 29, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#102336 (Fix associated type bindings with anon const in GAT position) - rust-lang#102342 (Add negation methods for signed non-zero integers.) - rust-lang#102385 (Don't export `__heap_base` and `__data_end` on wasm32-wasi.) - rust-lang#102435 (Improve example of Iterator::reduce) - rust-lang#102436 (rustdoc: clean up "normalize.css 8" input override CSS) - rust-lang#102452 (fix minor ungrammatical sentence) - rust-lang#102455 (Use let-chaining in `WhileTrue::check_expr`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2022
[beta] backports * Avoid duplicating StorageLive in let-else rust-lang#101894 * Re-add HRTB implied static bug note rust-lang#101924 * Revert "Copy stage0 binaries into stage0-sysroot" rust-lang#101942 * implied_bounds: deal with inference vars rust-lang#102016 * fix ConstProp handling of written_only_inside_own_block_locals rust-lang#102045 * Fix wrongly refactored Lift impl rust-lang#102088 * Fix a typo “pararmeter” in error message rust-lang#102119 * Deny associated type bindings within associated type bindings rust-lang#102338 * Continue migration of CSS themes rust-lang#101934 * Fix search result colors rust-lang#102369 * Fix unwind drop glue for if-then scopes rust-lang#102394 * Revert "Use getentropy when possible on all Apple platforms" rust-lang#102693 * Fix associated type bindings with anon const in GAT position rust-lang#102336 * Revert perf-regression 101620 rust-lang#102064 * `EscapeAscii` is not an `ExactSizeIterator` rust-lang#99880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit formats
type_of.rs, which is really hard to maintain since it uses a bunch of features likelet-chains andif letmatch arm bindings. Best if you just review the second two diffs.Fixes #102333