Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for CommandExt::groups #90747

Open
2 of 4 tasks
cuviper opened this issue Nov 10, 2021 · 3 comments
Open
2 of 4 tasks

Tracking Issue for CommandExt::groups #90747

cuviper opened this issue Nov 10, 2021 · 3 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Nov 10, 2021

Feature gate: #![feature(setgroups)]

This is a tracking issue for std::os::unix::process::CommandExt::groups.

Sets the supplementary group IDs for the calling process. Translates to a setgroups call in the child process.

Public API

// std::os::unix::process

pub trait CommandExt: Sealed {
    fn groups(&mut self, groups: &[u32]) -> &mut Command;
}

Steps / History

Unresolved Questions

  • None yet.
@cuviper cuviper added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Nov 10, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 10, 2021
Add a real tracking issue for `CommandExt::groups`

The `unstable` attribute referenced the closed RFE rust-lang#38527, so I filed tracking issue rust-lang#90747.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 10, 2021
Add a real tracking issue for `CommandExt::groups`

The `unstable` attribute referenced the closed RFE rust-lang#38527, so I filed tracking issue rust-lang#90747.
@KamilaBorowska
Copy link
Contributor

    fn groups(
        &mut self,
        #[cfg(not(target_os = "vxworks"))] groups: &[u32],
        #[cfg(target_os = "vxworks")] groups: &[u16],
    ) -> &mut process::Command;

I think the fact that groups uses a different type for VxWorks seems like a possible issue with the API. I understand that for backwards compatibility reasons gid uses a different type for VxWorks (albeit it may be worth fixing it anyway, see https://rust-lang.github.io/rfcs/1415-trim-std-os.html), but I see no reason to continue with this mistake for a nightly method.

@liff
Copy link

liff commented Sep 27, 2023

Is there a chance this will end up being stabilized, or is the type of the group ID a blocker here?

@Jisu-Woniu
Copy link

Any update on this? It's been half a year with no updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants