Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans::expr::trans_adt has unresolved questions #6573

Closed
catamorphism opened this issue May 18, 2013 · 3 comments · Fixed by #16511
Closed

trans::expr::trans_adt has unresolved questions #6573

catamorphism opened this issue May 18, 2013 · 3 comments · Fixed by #16511
Labels
A-codegen Area: Code generation E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@catamorphism
Copy link
Contributor

Two questions from a comment in this function: "is it sound to use the destination's repr on the base? would it ever be reasonable to be here with discr != 0?"
@catamorphism
Copy link
Contributor Author

(Fixing this would involve creating test cases that answer these questions.)

@emberian
Copy link
Member

Triage bump

@metajack
Copy link
Contributor

metajack commented Sep 5, 2013

Visiting for triage. Nothing to add.

@luqmana luqmana mentioned this issue Aug 15, 2014
Merged
bors added a commit that referenced this issue Aug 15, 2014
@bors
auto merge of #16511 : luqmana/rust/sbnt, r=pcwalton
02f9fd8 
Fixes #15397.
Fixes #7261.
Fixes #6573.
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 25, 2021
@bors
Auto merge of rust-lang#6573 - Jarcho:option_match_map, r=llogiq
a2c25fa 
New lint: option_manual_map

fixes: rust-lang#6
changelog: Added lint: `match_map`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup trans for structs with base expr. luqmana/rust
3 participants
@metajack @catamorphism @emberian