Tracking issue for future-incompatbility warning 'invalid literal suffix on tuple index' (not a lint)

[nikomatsakis]

This is the summary issue for a bug fix related to tuple indexing. The goal of this page is describe why this change was made and how you can fix code that is affected by it. It also provides a place to ask questions or register a complaint if you feel the change should not be made. For more information on the policy around future-compatibility warnings, see our breaking change policy guidelines.

What is the warning for?

As reported in #59418, the compiler incorrectly accepts foo.0_u32 (and other suffixes) when indexing into tuples. The expected syntax is simply foo.0. We are presently issuing warnings when this incorrect syntax is used but we expect to transition those warnings to errors in the future.

How can you fix your code?

Most often this error manifests in procedural macros that employ the syn or quote crates. It can be avoided by using syn::Index::from or proc_macro::Literal::*_unsuffixed. For example, if before you were generating foo.0 doing something like this:

let i = 0;
quote! { foo.$i }

you might now do instead:

let i = syn::Index::from(0);
quote! { foo.$i }

When will this warning become a hard error?

At the beginning of each 6-week release cycle, the Rust compiler team
will review the set of outstanding future compatibility warnings and
nominate some of them for Final Comment Period. Toward the end of
the cycle, we will review any comments and make a final determination
whether to convert the warning into a hard error or remove it
entirely.

Related bugs

Here are some of the regressions found in the wild:

• Tuple indexing regression #59553
• suffixes on a tuple index are invalid  #60138

[roblabla]

It appears to be impossible to promote this warning to an error? I've been trying to write a regression test in a proc macro to catch this error, but to no avail. See https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=933b66f963f15bda1c3b62d0ae19e517

[fmease]

It appears to be impossible to promote this warning to an error? I've been trying to write a regression test in a proc macro to catch this error, but to no avail. See https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=933b66f963f15bda1c3b62d0ae19e517

Good catch! This warning was never assigned to a specific lint (whether intentional or not). We should address that.