Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryHeap example should show how to make a min-heap. #58174

Closed
forrestthewoods opened this issue Feb 5, 2019 · 2 comments · Fixed by #60451
Closed

BinaryHeap example should show how to make a min-heap. #58174

forrestthewoods opened this issue Feb 5, 2019 · 2 comments · Fixed by #60451
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@forrestthewoods
Copy link

std::collections::BinaryHeap is a max-heap. A very common use case for users will be to make a min-heap. The basic example should include a min-heap.
@hellow554
Copy link
Contributor

Do you think you would be able to make a PR based on e.g. https://stackoverflow.com/questions/54489368/how-do-i-create-a-binaryheap-that-pops-the-smallest-value-not-the-largest ?

@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-help-wanted Call for participation: Help is requested to fix this issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. and removed E-help-wanted Call for participation: Help is requested to fix this issue. labels Apr 21, 2019
@rasendubi rasendubi mentioned this issue May 1, 2019
Merged
@rasendubi
Copy link
Contributor

Added an example in #60451

bors added a commit that referenced this issue May 10, 2019
@bors
Auto merge of #60451 - rasendubi:binaryheap-min-heap, r=scottmcm
407536e 
BinaryHeap: add min-heap example

Fixes #58174.
@scottmcm scottmcm mentioned this issue Sep 3, 2020
Closed
@scottmcm scottmcm mentioned this issue Oct 14, 2020
Closed
@scottmcm scottmcm mentioned this issue Jun 2, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BinaryHeap: add min-heap example rasendubi/rust
4 participants
@hellow554 @rasendubi @jonas-schievink @forrestthewoods