Tracking issue for std::collections::binary_heap::PeekMut::pop

[sfackler]

No description provided.

[windwardly]

I wrote something similar today, committed, pulled to tip and got a conflict with your f2cb47.

I merged, replaced in my tests, calling my function with calling yours . Works! Yay!
Thank you.

[windwardly]

Better or worse flipping the lines around? Looks more like a tail call:

        this.sift = false;
        this.heap.pop().unwrap()

[sfackler]

@rfcbot fcp merge

[rfcbot]

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

• @BurntSushi
• @Kimundi
• @alexcrichton
• @aturon
• @brson
• @sfackler

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rfcbot]

The final comment period is now complete.

[jhjourdan]

Any reason why the parameter of pop is not self ?

[sfackler]

@jhjourdan PeekMut implements Deref so we don't want to implement any methods on it. If the type of values in your heap had a pop method, you would suddenly start calling this method instead.

[jhjourdan]

Oh, right. Sorry for the noise.