Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fix the personality_fn setting in MIR trans #38462

Closed
nagisa opened this issue Dec 19, 2016 · 1 comment · Fixed by #39319
Closed

Properly fix the personality_fn setting in MIR trans #38462

nagisa opened this issue Dec 19, 2016 · 1 comment · Fixed by #39319

Comments

@nagisa
Copy link
Member

nagisa commented Dec 19, 2016 •
edited
Loading

#37862 has landed despite my repeated warnings this is a hack and should be fixed properly. This issue is a reminder for self to fix this properly once the larger PRs in queue land (the old trans cleanup and i128).

The fix would likely be as simple as fixing init_cpad function and reverting the whole patch from the linked PR.
@Mark-Simulacrum
Copy link
Member

Just leaving a note here so it's easier to find for whoever works on this: After #38302, init_cpad will not exist, but will be inlined into trans_mir.

@nagisa nagisa mentioned this issue Jan 26, 2017
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 2, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39319 - nagisa:remove-rustsetpersonalityfn,…
bcfa2f1 
… r=pnkfelix

Remove unnecessary LLVMRustPersonalityFn binding

LLVM Core C bindings provide this function for all the versions back to what we support (3.7), and
helps to avoid this unnecessary builder->function transition every time. Also a negative diff.

Fixes rust-lang#38462 (although it was pretty much fixed already)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary LLVMRustPersonalityFn binding nagisa/rust
2 participants
@nagisa @Mark-Simulacrum