Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0008 needs to be updated to new format #35496

Closed
sophiajt opened this issue Aug 8, 2016 · 3 comments
Closed

E0008 needs to be updated to new format #35496

sophiajt opened this issue Aug 8, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

From: src/test/compile-fail/E0008.rs

Error E0008 needs a span_label, updating it from:

error[E0008]: cannot bind by-move into a pattern guard
  --> src/test/compile-fail/E0008.rs:13:14
   |
13 |         Some(s) if s.len() == 0 => {}, //~ ERROR E0008
   |              ^

To:

error[E0008]: cannot bind by-move into a pattern guard
  --> src/test/compile-fail/E0008.rs:13:14
   |
13 |         Some(s) if s.len() == 0 => {}, //~ ERROR E0008
   |              ^ moves value into pattern guard
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 8, 2016
Closed
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 8, 2016
@srdja srdja mentioned this issue Aug 8, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 10, 2016
@steveklabnik
Rollup merge of rust-lang#35530 - srdja:master, r=jonathandturner
c65f1a5 
Update E0008 and E0007 to new format

Part of rust-lang#35233
A fix for rust-lang#35496

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 10, 2016
Rollup merge of rust-lang#35530 - srdja:master, r=jonathandturner
e7b0619 
Update E0008 and E0007 to new format

Part of rust-lang#35233
A fix for rust-lang#35496

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 11, 2016
Rollup merge of rust-lang#35530 - srdja:master, r=jonathandturner
c7513d7 
Update E0008 and E0007 to new format

Part of rust-lang#35233
A fix for rust-lang#35496

r? @jonathandturner
@marti1125
Copy link
Contributor

Hi @jonathandturner I would like to contribute with this =D

@killercup
Copy link
Member

@marti1125 I'm pretty sure this has already been fixed by #35530, this issue has just not been updated yet.

@marti1125
Copy link
Contributor

Oh thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@killercup @marti1125 @sophiajt