Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0206 needs to be updated to new format #35301

Closed
sophiajt opened this issue Aug 4, 2016 · 0 comments
Closed

E0206 needs to be updated to new format #35301

sophiajt opened this issue Aug 4, 2016 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/coherence-impls-copy.rs

Error E0206 needs a span_label and a title update, updating it from:

error[E0206]: the trait `Copy` may not be implemented for this type; type is not a structure or enumeration
  --> src/test/compile-fail/coherence-impls-copy.rs:40:1
   |
40 | impl Copy for [MyType] {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

To:

error[E0206]: the trait `Copy` may not be implemented for this type
  --> src/test/compile-fail/coherence-impls-copy.rs:40:1
   |
40 | impl Copy for [MyType] {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^ type is not a structure or enumeration

Bonus: fix the span so it's on the type rather than the whole impl:

error[E0206]: the trait `Copy` may not be implemented for this type
  --> src/test/compile-fail/coherence-impls-copy.rs:40:1
   |
40 | impl Copy for [MyType] {}
   |               ^^^^^^^^ type is not a structure or enumeration
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 6, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
bors added a commit that referenced this issue Aug 8, 2016
Update E0206 message to new format

Part of #35233.
Fixes #35301.

r? @GuillaumeGomez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

1 participant