Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0071 needs to be updated to new format #35220

Closed
sophiajt opened this issue Aug 2, 2016 · 1 comment
Closed

E0071 needs to be updated to new format #35220

sophiajt opened this issue Aug 2, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0071.rs

Error E0071 needs a span_label, updating it from:

error[E0071]: `Foo::FirstValue` does not name a struct or a struct variant
  --> src/test/compile-fail/E0071.rs:14:13
   |
14 |     let u = Foo::FirstValue { value: 0 }; //~ ERROR E0071
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0071]: `u32` does not name a struct or a struct variant
  --> src/test/compile-fail/E0071.rs:15:13
   |
15 |     let t = u32 { value: 4 }; //~ ERROR E0071
   |             ^^^^^^^^^^^^^^^^

To:

error[E0071]: `Foo::FirstValue` does not name a struct or a struct variant
  --> src/test/compile-fail/E0071.rs:14:13
   |
14 |     let u = Foo::FirstValue { value: 0 }; //~ ERROR E0071
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not a struct

error[E0071]: `u32` does not name a struct or a struct variant
  --> src/test/compile-fail/E0071.rs:15:13
   |
15 |     let t = u32 { value: 4 }; //~ ERROR E0071
   |             ^^^^^^^^^^^^^^^^ not a struct

Bonus: The span should underline only the name of the thing that's not a struct rather than the whole expression. Example:

error[E0071]: `u32` does not name a struct or a struct variant
  --> src/test/compile-fail/E0071.rs:15:13
   |
15 |     let t = u32 { value: 4 }; //~ ERROR E0071
   |             ^^^ not a struct

This may require additional compiler changes.

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@razielgn
Copy link
Contributor

razielgn commented Aug 3, 2016

Booking this one, as mentioned in #35233.

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 4, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 4, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants