Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0062 needs to be updated to new format #35217

Closed
sophiajt opened this issue Aug 2, 2016 · 1 comment
Closed

E0062 needs to be updated to new format #35217

sophiajt opened this issue Aug 2, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0062.rs

Error E0062 needs a span_label, updating it from:

error[E0062]: field `x` specified more than once
  --> src/test/compile-fail/E0062.rs:18:9
   |
18 |         x: 0, //~ ERROR E0062
   |         ^

To:

error[E0062]: field `x` specified more than once
  --> src/test/compile-fail/E0062.rs:18:9
   |
18 |         x: 0, //~ ERROR E0062
   |         ^ used more than once

Bonus: we should also include the span_label for the first time it was used as a secondary label.
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 3, 2016
Closed
@trixnz
Copy link
Contributor

trixnz commented Aug 4, 2016

Taking care of this one

@trixnz trixnz mentioned this issue Aug 4, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35328 - trixnz:update-error-62, r=jonathand…
11f3da8 
…turner

Update error format for E0062

Fixes rust-lang#35217 as part of rust-lang#35233

There seems to be an issue with the old format ignoring the labels which results in the incorrect line being rendered in the old format. I spoke with @jonathandturner about this and it seems to be a bug. Pertinent information [here](https://gist.github.com/trixnz/ad11e68687529e164427df8f8eb63116).

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35328 - trixnz:update-error-62, r=jonathand…
8b97008 
…turner

Update error format for E0062

Fixes rust-lang#35217 as part of rust-lang#35233

There seems to be an issue with the old format ignoring the labels which results in the incorrect line being rendered in the old format. I spoke with @jonathandturner about this and it seems to be a bug. Pertinent information [here](https://gist.github.com/trixnz/ad11e68687529e164427df8f8eb63116).

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiajt @trixnz