Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments documenting pipe implementation #3072

Closed
eholk opened this issue Aug 1, 2012 · 1 comment
Closed

Add comments documenting pipe implementation #3072

eholk opened this issue Aug 1, 2012 · 1 comment
Labels
A-concurrency Area: Concurrency related issues.

Comments

@eholk
Copy link
Contributor

eholk commented Aug 1, 2012

This is mostly a tracking bug for FIXMEs. The pipe compiler and runtime system should have enough comments that someone could read over them and understand how the system works and be able to fix bugs in it.

@ghost ghost assigned eholk Aug 1, 2012
@graydon
Copy link
Contributor

graydon commented Apr 24, 2013

every fixme has a bug now, so closing this.

@graydon graydon closed this as completed Apr 24, 2013
@eholk eholk removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Sep 25, 2023
Implement `llvm.ctpop.v*` intrinsics

Tested through x86 avx512vpopcntdq and avx512bitalg functions.

I picked them from rust-lang/miri#2057 (comment), which looked easy.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
…ust-lang#3245)

Using stubs or function contracts as part of the `verify-std`
sub-command does not work with multiple rustc executions as previous
implementation. This happens because we now enable verifying
dependencies, and cargo crashes due to a race condition. As soon as the
first rustc invocation succeeds, cargo starts the compilation of the
dependents crate. However, new executions can override files.

Instead, we moved the stub logic to the new transformation framework,
which is done on the top of the StableMIR body, and doesn't affect the
Rust compiler session. We are now able to apply stub without restarting
the compiler. This is a much better user experience as well, since
multiple calls to the compiler can print the same warnings multiple
times.

Resolves rust-lang#3072
Towards rust-lang#3152 


Co-authored-by: Felipe R. Monteiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-concurrency Area: Concurrency related issues.
Projects
None yet
Development

No branches or pull requests

2 participants