Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move checking of tests with little x-platform risk to supplemental auto bot, turn on lexer tests #15880

Closed
brson opened this issue Jul 21, 2014 · 4 comments
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. P-low Low priority

Comments

@brson
Copy link
Contributor

brson commented Jul 21, 2014

We have tests in tree that the lexer conforms to an official grammar, but the bots are not running them yet. These tests take a long time to run, as will the impending tests of the parser. We need to do a few things to turn them on:

  • Port grammar and lexer tests to rustbuild from grammar.mk
  • Add a make check-extra in src/bootstrap/mk/makefile.in that runs the grammar and lexer tests. Submit PR to rust-lang/rust
  • Create a Dockerfile that is capable of running the tests
  • Make modifications to rust-buildbot that a new auto-extra builder
  • Submit PR to rust-buildbot.

cc @cmr @alexcrichton

@emberian
Copy link
Member

The lexer tests aren't too bad, but the parser tests are going to be awful.

@emberian
Copy link
Member

It looks like the Ubuntu antlr packages are not-very-useful, will have to install from their website. It's missing the grun tool entirely, which is the only thing that lets me avoid actually writing Java for the lexer tests.

@brson brson self-assigned this Aug 4, 2014
@brson brson mentioned this issue Sep 17, 2014
65 tasks
@brson brson removed their assignment Mar 12, 2015
@brson brson added the P-low Low priority label Aug 22, 2016
@edunham
Copy link
Member

edunham commented Aug 22, 2016

Help wanted: Create Docker image with all dependencies to run these tests, and take a guess at the Buildbot PR necessary to run the new image as a non-gating builder.

@alexcrichton
Copy link
Member

Grammar bot is #28592 and otherwise we basically have a supplemental bot running extra tests.

bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2023
internal: Include toml files in the vfs

Closes rust-lang#15753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. P-low Low priority
Projects
None yet
Development

No branches or pull requests

4 participants