-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"command did not execute successfully" message is too verbose when tool fails to compile #122706
Labels
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
Noratrieb
added
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
C-bug
Category: This is a bug.
labels
Mar 18, 2024
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Mar 18, 2024
Noratrieb
removed
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Mar 18, 2024
jhpratt
added a commit
to jhpratt/rust
that referenced
this issue
Mar 21, 2024
… r=clubby789 make failure logs less verbose Resolves rust-lang#122706 Logs without verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/f2fc2d35-0954-44b0-bedc-045afedaabe8) Logs with verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/b9308655-ad31-4527-a1be-5a62a78ac469) I decided to exclude command from the log since it's already included in verbose mode. cc `@Nilstrieb`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 21, 2024
… r=clubby789 make failure logs less verbose Resolves rust-lang#122706 Logs without verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/f2fc2d35-0954-44b0-bedc-045afedaabe8) Logs with verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/b9308655-ad31-4527-a1be-5a62a78ac469) I decided to exclude command from the log since it's already included in verbose mode. cc ``@Nilstrieb``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 22, 2024
… r=clubby789 make failure logs less verbose Resolves rust-lang#122706 Logs without verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/f2fc2d35-0954-44b0-bedc-045afedaabe8) Logs with verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/b9308655-ad31-4527-a1be-5a62a78ac469) I decided to exclude command from the log since it's already included in verbose mode. cc ```@Nilstrieb```
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Mar 22, 2024
Rollup merge of rust-lang#122831 - onur-ozkan:less-verbose-fail-logs, r=clubby789 make failure logs less verbose Resolves rust-lang#122706 Logs without verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/f2fc2d35-0954-44b0-bedc-045afedaabe8) Logs with verbose flag: ![image](https://github.com/rust-lang/rust/assets/39852038/b9308655-ad31-4527-a1be-5a62a78ac469) I decided to exclude command from the log since it's already included in verbose mode. cc ```@Nilstrieb```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When making a tool (like tidy) not compile, I get the following error:
This is way too verbose, I do not care about the environment variables and all of these useless empty lines at the end. It obscures the rustc error, especially in a terminal without much scollback like the default VSCode one at the bottom. This information should only be shown when using
-v
.The text was updated successfully, but these errors were encountered: