Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check broken on windows #10452

Closed
klutzy opened this issue Nov 13, 2013 · 2 comments · Fixed by #10472
Closed

make check broken on windows #10452

klutzy opened this issue Nov 13, 2013 · 2 comments · Fixed by #10472
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@klutzy
Copy link
Contributor

klutzy commented Nov 13, 2013

We only run make check-fast on windows due to slowness (#8844), but in theory it should work. It doesn't now.
@klutzy klutzy mentioned this issue Nov 13, 2013
Closed
@klutzy
Copy link
Contributor Author

klutzy commented Nov 13, 2013

My result with gcc 4.6:

failures:
    [run-pass] run-pass/glob-std.rs
    [run-pass] run-pass/linkage-visibility.rs
    [run-pass] run-pass/signal-exit-status.rs
    [run-pass] run-pass/struct-update-moves-and-copies.rs
    [run-pass] run-pass/tempfile.rs

test result: FAILED. 1314 passed; 5 failed; 54 ignored; 0 measured

gcc 4.8 result has 4 more failures due to #9205: we xfail-fasted them so they are only skipped on check-fast.

@klutzy
Copy link
Contributor Author

klutzy commented Nov 13, 2013

struct-update-moves-and-copies error is...

$ ./i686-pc-mingw32/test/run-pass/struct-update-moves-and-copies.stage2-i686-pc-mingw32.exe
sh: ./i686-pc-mingw32/test/run-pass/struct-update-moves-and-copies.stage2-i686-pc-mingw32.exe: Bad file number

... because UAC (at least on win 8.1 preview) saw the word "update" in filename then blocked it. :(

Others are just xfail-fasted. We could use xfail-win32 instead, but some of them may be fixable.

@klutzy klutzy mentioned this issue Nov 13, 2013
Closed
@klutzy klutzy mentioned this issue Nov 14, 2013
Closed
This was referenced Nov 14, 2013
Merged
Closed
klutzy added a commit to klutzy/rust that referenced this issue Nov 14, 2013
@klutzy
test: Clean up xfail-{fast,win32} tests
fcf9844 
Rename {struct-update,fsu}-moves-and-copies, since win32
failed to run the test since UAC prevents any executable whose
name contaning "update". (rust-lang#10452)

Some tests related to rust-lang#9205 are expected to fail on gcc 4.8,
so they are marked as `xfail-win32` instead of `xfail-fast`.

Some tests using `extra::tempfile` fail on win32 due to rust-lang#10462.
Mark them as `xfail-win32`.
@bors bors closed this as completed in 51f2e7e Nov 14, 2013
This was referenced Nov 16, 2013
Closed
Closed
@klutzy klutzy mentioned this issue Nov 20, 2013
Closed
@klutzy klutzy mentioned this issue Mar 7, 2014
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue May 5, 2023
@bors
Auto merge of rust-lang#10679 - y21:better-const-ctx-check, r=Jarcho
496c110 
use `is_inside_const_context` for `in_constant` util fn

Fixes rust-lang#10452.

This PR improves the `in_constant` util function to detect more cases of const contexts. Previously this function would not detect cases like expressions in array length position or expression in an inline const block `const { .. }`.

changelog: [`bool_to_int_with_if`]: recognize array length operand as being in a const context and don't suggest `usize::from` there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix make check on win32 klutzy/rust
1 participant
@klutzy