Add lint `manual_inspect` #12287

Jarcho · 2024-02-12T23:37:48Z

A great example of a lint that sounds super simple, but has a pile of edge cases.

changelog: Add lint manual_inspect

rustbot · 2024-02-12T23:37:53Z

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bors · 2024-02-19T09:36:55Z

☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.

llogiq · 2024-02-24T11:12:52Z

clippy_lints/src/methods/manual_inspect.rs

+
+use super::MANUAL_INSPECT;
+
+#[expect(clippy::too_many_lines)]


might make sense to factor out some methods?

There are distinct parts which it could be split at, but that would just end up with functions taking 5+ arguments and multiple return values. Not really an improvement.

llogiq

This looks sensible. I have but one nit, but if you feel it's too much work to refactor that method, I'm ok with just merging it after a rebase.

llogiq · 2024-02-29T11:36:52Z

@rustbot author

mpalmer · 2024-04-28T03:22:06Z

Hey @Jarcho, are you up for getting this rebased / refactored for merge? If not, lmk and I'll have a crack at it. I'd like to see this lint land, as I'm sure I've been guilty of this now and then in the past.

llogiq · 2024-06-15T11:09:35Z

Thanks for seeing this through.

@bors r+

bors · 2024-06-15T11:09:38Z

📌 Commit 404a6de has been approved by llogiq

It is now in the queue for this repository.

bors · 2024-06-15T11:10:45Z

⌛ Testing commit 404a6de with merge debcef0...

Add lint `manual_inspect` fixes #12250 A great example of a lint that sounds super simple, but has a pile of edge cases. changelog: Add lint `manual_inspect`

bors · 2024-06-15T11:11:57Z

💔 Test failed - checks-action_dev_test

llogiq · 2024-06-16T18:33:50Z

@bors retry

Add lint `manual_inspect` fixes #12250 A great example of a lint that sounds super simple, but has a pile of edge cases. ---- changelog: Add lint `manual_inspect`

bors · 2024-06-16T18:34:59Z

⌛ Testing commit 404a6de with merge aae7ddb...

bors · 2024-06-16T18:36:21Z

💔 Test failed - checks-action_dev_test

* Delay the parsing of the use node * Mark when the `SyntaxContext` changes rather than return `None` * Return a default value if the HIR tree is broken rather than `None`

llogiq · 2024-06-16T22:53:33Z

Ok, let's try once more.

@bors r+

bors · 2024-06-16T22:53:35Z

📌 Commit 22710f3 has been approved by llogiq

It is now in the queue for this repository.

bors · 2024-06-16T22:54:42Z

⌛ Testing commit 22710f3 with merge 16efa56...

bors · 2024-06-16T23:02:54Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 16efa56 to master...

Summary: Upgrading Rust from `1.80.1` to `1.81.0` ([release notes](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html)) with the following changes affecting `fbsource`: * Feature stabilizations: * `io_slice_advance` ([#62726](rust-lang/rust#62726)) * `panic_info_message` ([#66745](rust-lang/rust#66745)) * `fs_try_exists` ([#83186](rust-lang/rust#83186)) * `lint_reasons` ([#120924](rust-lang/rust#120924)) * `duration_abs_diff` ([#117618](rust-lang/rust#117618)) * `effects` ([#102090](rust-lang/rust#102090)) * New `clippy` lints: * `manual_inspect` ([#12287](rust-lang/rust-clippy#12287)) * `manual_pattern_char_comparison` ([#12849](rust-lang/rust-clippy#12849)) * Other: * `NEVER_TYPE_FALLBACK_FLOWING_INTO_UNSAFE` became a deny-by-default lint ([#126881](rust-lang/rust#126881) & [#123748](rust-lang/rust#123748)) * Changes to `stringify!` introducing whitespaces between some tokens ([#125174](rust-lang/rust#125174)) * `format!` is now marked with a `must_use` hint ([#127355](rust-lang/rust#127355)) ignore-conflict-markers Reviewed By: zertosh, dtolnay Differential Revision: D63864870 fbshipit-source-id: c8d61f3e9483ec709c8116514cfb030c883ec262

rustbot assigned llogiq Feb 12, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2024

y21 mentioned this pull request Feb 12, 2024

Suggest inspect_err instead of map_err with a closure that returns the original error #12250

Closed

Jarcho force-pushed the issue_12250 branch 5 times, most recently from 65439cf to 509614b Compare February 13, 2024 23:22

llogiq reviewed Feb 24, 2024

View reviewed changes

llogiq approved these changes Feb 24, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Feb 29, 2024

Jarcho force-pushed the issue_12250 branch from 509614b to 404a6de Compare June 7, 2024 00:47

bors added a commit that referenced this pull request Jun 15, 2024

Auto merge of #12287 - Jarcho:issue_12250, r=llogiq

debcef0

Add lint `manual_inspect` fixes #12250 A great example of a lint that sounds super simple, but has a pile of edge cases. changelog: Add lint `manual_inspect`

bors added a commit that referenced this pull request Jun 16, 2024

Auto merge of #12287 - Jarcho:issue_12250, r=llogiq

aae7ddb

Add lint `manual_inspect` fixes #12250 A great example of a lint that sounds super simple, but has a pile of edge cases. ---- changelog: Add lint `manual_inspect`

expr_use_ctxt changes:

a002f93

* Delay the parsing of the use node * Mark when the `SyntaxContext` changes rather than return `None` * Return a default value if the HIR tree is broken rather than `None`

Jarcho force-pushed the issue_12250 branch from 404a6de to c10ea04 Compare June 16, 2024 22:05

Add lint manual_inspect

22710f3

Jarcho force-pushed the issue_12250 branch from c10ea04 to 22710f3 Compare June 16, 2024 22:33

bors merged commit 16efa56 into rust-lang:master Jun 16, 2024
11 checks passed

bors mentioned this pull request Jun 16, 2024

Unnecessary call to min/max method #12368

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint `manual_inspect` #12287

Add lint `manual_inspect` #12287

Jarcho commented Feb 12, 2024 •

edited by llogiq

Loading

rustbot commented Feb 12, 2024

bors commented Feb 19, 2024

llogiq Feb 24, 2024

Jarcho Jun 7, 2024

llogiq left a comment •

edited

Loading

llogiq commented Feb 29, 2024

mpalmer commented Apr 28, 2024

llogiq commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 15, 2024

llogiq commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

llogiq commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

Add lint manual_inspect #12287

Add lint manual_inspect #12287

Conversation

Jarcho commented Feb 12, 2024 • edited by llogiq Loading

rustbot commented Feb 12, 2024

bors commented Feb 19, 2024

llogiq Feb 24, 2024

Choose a reason for hiding this comment

Jarcho Jun 7, 2024

Choose a reason for hiding this comment

llogiq left a comment • edited Loading

Choose a reason for hiding this comment

llogiq commented Feb 29, 2024

mpalmer commented Apr 28, 2024

llogiq commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 15, 2024

llogiq commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

llogiq commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

Add lint `manual_inspect` #12287

Add lint `manual_inspect` #12287

Jarcho commented Feb 12, 2024 •

edited by llogiq

Loading

llogiq left a comment •

edited

Loading