RFC: Support char::encode_utf8 in const scenarios.
#3696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionale and alternatives.
|
Changes this small don't require an RFC. |
|
Oh, alright then. I'll just submit the implementation directly. Should I just close this PR now? |
|
libs-api needs to discuss all library-related API changes. A PR to rust-lang/rust with a libs-api reviewer is fine for anything relatively trivial (like this, adding It looks like you already put a PR up at rust-lang/rust#130511, so this can be closed. Thanks for putting in the effort! |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 19, 2024
… r=dtolnay Support `char::encode_utf8` in const scenarios. This PR implements [`rust-lang/rfcs#3696`](rust-lang/rfcs#3696). This assumes [`const_slice_from_raw_parts_mut`](rust-lang#67456).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2024
…=dtolnay Support `char::encode_utf8` in const scenarios. This PR implements [`rust-lang/rfcs#3696`](rust-lang/rfcs#3696). This assumes [`const_slice_from_raw_parts_mut`](rust-lang#67456).
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Sep 21, 2024
Support `char::encode_utf8` in const scenarios. This PR implements [`rust-lang/rfcs#3696`](rust-lang/rfcs#3696). This assumes [`const_slice_from_raw_parts_mut`](rust-lang/rust#67456).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
encode_utf8method incharshould be marked const to support compile-time conversions.Rendered