Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'open-namespaces' feature #13591

Merged
merged 4 commits into from
Mar 15, 2024
Merged

feat: Add 'open-namespaces' feature #13591

merged 4 commits into from
Mar 15, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Mar 15, 2024

What does this PR try to resolve?

This is a step towards #13576

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation A-unstable Area: nightly unstable support S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@rustbot rustbot added the A-manifest Area: Cargo.toml issues label Mar 15, 2024
weihanglo
weihanglo approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just one question about read-manifest.

crates/cargo-util-schemas/src/restricted_names.rs Show resolved Hide resolved
tests/testsuite/open_namespaces.rs Show resolved Hide resolved
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 15, 2024

📌 Commit de5ac27 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 15, 2024

📌 Commit 9ea3f26 has been approved by weihanglo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 15, 2024

⌛ Testing commit 9ea3f26 with merge 2fe739f...

@bors
Copy link
Contributor

bors commented Mar 15, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 2fe739f to master...

@bors bors merged commit 2fe739f into rust-lang:master Mar 15, 2024
21 checks passed
@epage epage deleted the namespace branch March 15, 2024 22:48
@weihanglo weihanglo mentioned this pull request Mar 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2024
@bors
Auto merge of rust-lang#122575 - weihanglo:update-cargo, r=weihanglo
05a2be3 
Update cargo

6 commits in 7065f0ef4aa267a7455e1c478b5ccacb7baea59c..2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b
2024-03-12 13:25:15 +0000 to 2024-03-15 21:39:18 +0000
- feat: Add 'open-namespaces' feature (rust-lang/cargo#13591)
- refactor: Expose source/spans to Manifest for emitting lints (rust-lang/cargo#13593)
- feat(tree): Control `--charset` via auto-detecting config value (rust-lang/cargo#13337)
- refactor(toml): Flatten manifest parsing (rust-lang/cargo#13589)
- fix: strip feature dep when dep is dev dep (rust-lang/cargo#13518)
- fix(ci): bump check error when PR is behind master (rust-lang/cargo#13581)

r? ghost
@epage epage mentioned this pull request Mar 16, 2024
Open
5 tasks
@rustbot rustbot added this to the 1.78.0 milestone Mar 16, 2024
@epage epage mentioned this pull request Mar 17, 2024
Open
9 tasks
Nemo157
Nemo157 reviewed Mar 17, 2024
View reviewed changes
tests/testsuite/open_namespaces.rs
"kind": [
"lib"
],
"name": "foo::bar",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding from the RFC was that the library name was meant to just be bar, that would avoid the rustc issue you noted

The autogenerated lib.name key for such a crate will just be bar, the leaf crate name, and the expectation is that to use such crates one must use --extern foo::bar=bar.rlib syntax. There may be some better things possible here, perhaps foo_bar can be used here.
—https://rust-lang.github.io/rfcs/3243-packages-as-optional-namespaces.html#reference-level-explanation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'd assume this also applies to the autogenerated bin.name for src/main.rs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 left review comments

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-documenting-cargo-itself Area: Cargo's documentation A-manifest Area: Cargo.toml issues A-unstable Area: nightly unstable support S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@epage @rustbot @weihanglo @bors @Nemo157