Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update auto labels #13244

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: update auto labels #13244

merged 3 commits into from
Jan 3, 2024

Conversation

weihanglo
Copy link
Member

See

  • A-errors has been renamed to A-diagnostics
  • Some manifest related modules were moved to cargo-util-schemas.

@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2024

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2024
Comment on lines -123 to -124
[autolabel."A-errors"]
trigger_files = ["src/cargo/util/diagnostic_server.rs"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it deleted the trigger, was that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like that diagnostic_server.rs should belong to Command-fix, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was not clear. I was confused that this is adding this empty table:

[autolabel."A-diagnostics"]

for A-diagnostics without any keys. If that table is not needed, I'm not clear why it is being added (I wasn't sure if there was a trigger_files intended to be added here).

Feel free to r=ehuss either way.

@weihanglo
Copy link
Member Author

A-errors auto-label has been removed.

@bors r=ehuss

@bors
Copy link
Contributor

bors commented Jan 3, 2024

📌 Commit 872f4df has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2024
@bors
Copy link
Contributor

bors commented Jan 3, 2024

⌛ Testing commit 872f4df with merge e045049...

@bors
Copy link
Contributor

bors commented Jan 3, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing e045049 to master...

@bors bors merged commit e045049 into rust-lang:master Jan 3, 2024
20 checks passed
@weihanglo weihanglo deleted the auto-label branch January 3, 2024 21:25
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2024
Update cargo

10 commits in add15366eaf3f3eb84717d3b8b71902ca36a7c84..2ce45605d9db521b5fd6c1211ce8de6055fdb24e
2024-01-02 03:24:42 +0000 to 2024-01-04 18:04:13 +0000
- feat(embedded): Add prefix-char frontmatter syntax support (rust-lang/cargo#13247)
- Update dependency handlebars to v5 for mdman. (rust-lang/cargo#13249)
- Deprecate rustc plugin support in cargo (rust-lang/cargo#13248)
- feat(embedded): Add multiple experimental manifest syntaxes (rust-lang/cargo#13241)
- chore: update auto labels (rust-lang/cargo#13244)
- test: support publish package with a `public` field. (rust-lang/cargo#13245)
- `cargo fix`: Call rustc fewer times. (rust-lang/cargo#13243)
- chore: tracing be compat with rustc_log (rust-lang/cargo#13239)
- chore(deps): update compatible (rust-lang/cargo#13227)
- Contrib: Fix team HackMD links (rust-lang/cargo#13237)

r? ghost
@rustbot rustbot added this to the 1.77.0 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants