[beta] Backport GitHub RSA key revocation #11892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-key, r=arlosi Added new GitHub RSA Host Key GitHub rotated their RSA host key which means that cargo needs to update it. Thankfully the other keys were not rotated so the impact depends on how cargo connected to github. Refs https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
Add the old github keys as revoked The patch to update the bundled ssh github host key did not change anything for users who already had connected to github one time before via ssh: if the attacker had access to the old key, they'd be vulnerable to MITM attacks as their known_hosts file would list the old github key. Only if they connected again to github without attacker access, or if they saw the announcement of the key rotation, they would update their key. There is sadly no other way to distribute revocations of old host keys to clients other than to bundle them with client software. cc rust-lang#11883
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
|
|
Thanks! @bors r+ |
weihanglo
approved these changes
Mar 26, 2023
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2023
…anglo [beta-1.69-cargo] Backport GitHub RSA key revocation 1 commits in 7b18c85808a6b45ec8364bf730617b6f13e0f9f8..713164a40962a0a76c7f3ad8aafb6f03410e21d2 2023-03-17 12:29:33 +0000 to 2023-03-26 20:05:25 +0000 - [beta] Backport GitHub RSA key revocation (rust-lang/cargo#11892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports for 1.69.0: