Tracking Issue for --lockfile-path

[weihanglo]

Summary

Original issue: #5707
Implementation: #14326
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lockfile-path

Added a new flag --lockfile-path that allows users to specify a path to lockfile other than the default path <workspace_root>/Cargo.lock.

Unresolved Issues

• How this should work if the lockfile or a parent directory is not present
  • In #14326, missing parent directories will be created when Cargo is about to write the lockfile. This minimizes the chance of creating dangling directories.
• cargo install --lockfile-path implies --locked, and requires the alternaive lockfile to exist.
  • This behavior diverges from other commands, which allow the absence of lockfile at the alternative path.

Future Extensions

No response

Tasks

• Add an unstable doc under https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lockfile-path doc: add lockfile-path unstable doc section #14423
• cargo install should make --lockfile-path imply --locked feat: lockfile path implies --locked on cargo install #14556
• Shell completions.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

[Ifropc]

@rustbot claim

[Ifropc]

As far as shell completions go, I don't think we need to do anything in the scope of this task. In fact, it's alreadyready working on the latest nightly (as part of #14520)

[epage]

@Ifropc thats the new, unstable completion system.

The task is referring to our handwritten, stable completions

• https://github.com/rust-lang/cargo/blob/master/src/etc/_cargo
• https://github.com/rust-lang/cargo/blob/master/src/etc/cargo.bashcomp.sh

[epage]

That said, you could add a custom completer to the new completion system that restricts completions to files named Cargo.lock using PathCompleter::file().filter(...), see https://docs.rs/clap_complete/latest/clap_complete/engine/struct.PathCompleter.html

[Ifropc]

Got it, I will add the support into the stable system + will do the lock filter in the new system. Thought the unstable stuff is automatically grouped into the unstable autocomplete system as well, but guess it's a separate matter.
Thanks Ed!