Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update token permissions check and scoring #3755

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

naveensrinivasan
Copy link
Member

  • Update message for when no tokens are found

[checks/evaluation/permissions/permissions.go]

  • Change the message for when no tokens are found from "no github tokens found" to "no tokens found"

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #3755 (eff0c4b) into main (69bb742) will decrease coverage by 7.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
- Coverage   75.96%   68.93%   -7.04%     
==========================================
  Files         227      227              
  Lines       15356    15356              
==========================================
- Hits        11665    10585    -1080     
- Misses       2973     4125    +1152     
+ Partials      718      646      -72     

- Update message for when no tokens are found

[checks/evaluation/permissions/permissions.go]
- Change the message for when no tokens are found from "no github tokens found" to "no tokens found"

Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan naveensrinivasan merged commit 9986f70 into main Dec 30, 2023
38 checks passed
@naveensrinivasan naveensrinivasan deleted the naveen/fix/incorrect-token-message branch December 30, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants