🌱 Gitlab search API tests #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
+ Coverage 62.34% 62.51% +0.17%
==========================================
Files 178 178
Lines 12876 12876
==========================================
+ Hits 8028 8050 +22
+ Misses 4409 4385 -24
- Partials 439 441 +2 |
spencerschrock
approved these changes
Aug 11, 2023
- Add tests for `search()` function, including valid response and error handling Signed-off-by: naveensrinivasan <[email protected]>
- Add test for valid search with zero results - Update expected response for valid search with zero results - Update failure fetching search test [clients/gitlabrepo/testdata/valid-search-result-1] - Add an empty array to the `valid-search-result-1` test file [clients/gitlabrepo/search_test.go] - Add a test for valid search with zero results - Change the expected response for a valid search with zero results - Update the failure fetching search test Signed-off-by: naveensrinivasan <[email protected]>
d3df318
to
6a9209f
Compare
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* 🌱 Gitlab search API tests - Add tests for `search()` function, including valid response and error handling Signed-off-by: naveensrinivasan <[email protected]> * Improve search tests and data - Add test for valid search with zero results - Update expected response for valid search with zero results - Update failure fetching search test [clients/gitlabrepo/testdata/valid-search-result-1] - Add an empty array to the `valid-search-result-1` test file [clients/gitlabrepo/search_test.go] - Add a test for valid search with zero results - Change the expected response for a valid search with zero results - Update the failure fetching search test Signed-off-by: naveensrinivasan <[email protected]> --------- Signed-off-by: naveensrinivasan <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search()function, including valid response and error handlingWhat kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)