🌱 Improve GitLab repo status and webhook tests #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update test names and response paths for statuses and webhooks - Lower the numeric tolerance for test files - Change the error message when fetching webhooks [clients/gitlabrepo/statuses_test.go] - Change the name of the test from "valid webhook" to "valid status" - Change the name of the test from "invalid webhook" to "failure fetching the status" - Lower the numeric tolerance for test files - Change the response path for the valid status test from "./testdata/valid-status" to "./testdata/invalid-status" [clients/gitlabrepo/webhook_test.go] - Change the error message when fetching webhooks from "invalid webhook" to "failure fetching webhooks" Signed-off-by: naveensrinivasan <[email protected]>
spencerschrock
approved these changes
Aug 9, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
===========================================
- Coverage 74.14% 62.34% -11.80%
===========================================
Files 178 178
Lines 12876 12876
===========================================
- Hits 9547 8028 -1519
- Misses 2788 4409 +1621
+ Partials 541 439 -102 |
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
- Update test names and response paths for statuses and webhooks - Lower the numeric tolerance for test files - Change the error message when fetching webhooks [clients/gitlabrepo/statuses_test.go] - Change the name of the test from "valid webhook" to "valid status" - Change the name of the test from "invalid webhook" to "failure fetching the status" - Lower the numeric tolerance for test files - Change the response path for the valid status test from "./testdata/valid-status" to "./testdata/invalid-status" [clients/gitlabrepo/webhook_test.go] - Change the error message when fetching webhooks from "invalid webhook" to "failure fetching webhooks" Signed-off-by: naveensrinivasan <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test names and response paths for statuses and webhooks
Change the error message when fetching webhooks
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)