-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 E2e Gitlab Issues #3343
🌱 E2e Gitlab Issues #3343
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
===========================================
- Coverage 73.62% 61.89% -11.74%
===========================================
Files 178 178
Lines 12864 12864
===========================================
- Hits 9471 7962 -1509
- Misses 2854 4462 +1608
+ Partials 539 440 -99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested more details. The PR template was empty, and the test didn't clarify much.
I have updated it. This is e2e tests for GitLab issues. The Gitlab issues API requires additional permissions that would prevent the normal token from fetching the issues. |
- Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues [clients/gitlabrepo/issues_e2e_test.go] - Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues Signed-off-by: naveensrinivasan <[email protected]>
- Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available [clients/gitlabrepo/issues_e2e_test.go] - Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available Signed-off-by: naveensrinivasan <[email protected]>
- Update context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test to return errors when listing for issues with normal token [clients/gitlabrepo/issues_e2e_test.go] - Change context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test from "returns branches for the repo" to "returns errors when listing for issues with normal token" Signed-off-by: naveensrinivasan <[email protected]>
d6f8659
to
a4b6825
Compare
* 🌱 Add E2E tests for Gitlab repo issues - Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues [clients/gitlabrepo/issues_e2e_test.go] - Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues Signed-off-by: naveensrinivasan <[email protected]> * Improve issue e2e tests & error handling - Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available [clients/gitlabrepo/issues_e2e_test.go] - Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available Signed-off-by: naveensrinivasan <[email protected]> * Improve GitLab issues error handling - Update context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test to return errors when listing for issues with normal token [clients/gitlabrepo/issues_e2e_test.go] - Change context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test from "returns branches for the repo" to "returns errors when listing for issues with normal token" Signed-off-by: naveensrinivasan <[email protected]> --------- Signed-off-by: naveensrinivasan <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
What kind of change does this PR introduce?
E2e tests for Gitlab issues. The list issues will fail as it requires additional permissions.
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)