🌱 Improve gitlabrepo.ListProgrammingLanguages e2e tests
#3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
===========================================
- Coverage 72.56% 61.50% -11.06%
===========================================
Files 173 173
Lines 12686 12686
===========================================
- Hits 9205 7803 -1402
- Misses 2979 4456 +1477
+ Partials 502 427 -75 |
3f1de9c
to
0472227
Compare
spencerschrock
approved these changes
Jul 25, 2023
0472227
to
928e42a
Compare
- Add an end-to-end test for the `gitlabrepo.ListProgrammingLanguages` function - Include a test for repos without code to check that no programming languages are returned [clients/gitlabrepo/languages_e2e_test.go] - Add an e2e test for the `gitlabrepo.ListProgrammingLanguages` function - Add a test for repos without code to check that no programming languages are returned Signed-off-by: naveensrinivasan <[email protected]>
- Lower the numeric tolerance for e2e tests in the GitLab repository [clients/gitlabrepo/languages_e2e_test.go] - Lower numeric tolerance for test files Signed-off-by: naveensrinivasan <[email protected]>
928e42a
to
8807a13
Compare
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* 🌱 Improve `gitlabrepo.ListProgrammingLanguages` e2e tests - Add an end-to-end test for the `gitlabrepo.ListProgrammingLanguages` function - Include a test for repos without code to check that no programming languages are returned [clients/gitlabrepo/languages_e2e_test.go] - Add an e2e test for the `gitlabrepo.ListProgrammingLanguages` function - Add a test for repos without code to check that no programming languages are returned Signed-off-by: naveensrinivasan <[email protected]> * Increase test accuracy for language e2e tests - Lower the numeric tolerance for e2e tests in the GitLab repository [clients/gitlabrepo/languages_e2e_test.go] - Lower numeric tolerance for test files Signed-off-by: naveensrinivasan <[email protected]> --------- Signed-off-by: naveensrinivasan <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitlabrepo.ListProgrammingLanguagesfunction[clients/gitlabrepo/languages_e2e_test.go]
gitlabrepo.ListProgrammingLanguagesfunctionWhat kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)