Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [experimental] Add a new format for details #2917

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Apr 26, 2023

This PR adds a new format finding to improve on the existing json format. This new format will be the same as json, but will display the details in a more structured format.

Note that this is not the final "structured" format. This is a simpler version of it.

I have named the format "finding" because it's the underlying structure that will be used to populate it, but please suggest a better name.

Add a new format for details

@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2023 16:27 — with GitHub Actions Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2023 16:29 — with GitHub Actions Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2023 16:30 — with GitHub Actions Inactive
pkg/json.go Show resolved Hide resolved
pkg/json.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2917 (4dc14a4) into main (f3b7770) will increase coverage by 0.23%.
The diff coverage is 42.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2917      +/-   ##
==========================================
+ Coverage   52.42%   52.66%   +0.23%     
==========================================
  Files         158      158              
  Lines       12108    12057      -51     
==========================================
+ Hits         6348     6350       +2     
+ Misses       5390     5337      -53     
  Partials      370      370              

@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2023 16:37 — with GitHub Actions Inactive
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2023 17:14 — with GitHub Actions Inactive
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to what the difference between the three experimental formats will be.

I think its fine for the names to be a WIP if this is experimental.

@laurentsimon laurentsimon enabled auto-merge (squash) April 26, 2023 18:25
@laurentsimon laurentsimon merged commit 813e9c6 into ossf:main Apr 26, 2023
@laurentsimon laurentsimon changed the title ✨ Add a new format for details ✨ [experimental] Add a new format for details Apr 26, 2023
balteravishay pushed a commit to balteravishay/scorecard that referenced this pull request May 29, 2023
* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

---------

Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: Avishay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants