-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [experimental] Add a new format for details #2917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
azeemshaikh38,
justaugustus,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
April 26, 2023 16:26
laurentsimon
temporarily deployed
to
integration-test
April 26, 2023 16:27
— with
GitHub Actions
Inactive
laurentsimon
temporarily deployed
to
integration-test
April 26, 2023 16:29
— with
GitHub Actions
Inactive
laurentsimon
temporarily deployed
to
integration-test
April 26, 2023 16:30
— with
GitHub Actions
Inactive
laurentsimon
commented
Apr 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
+ Coverage 52.42% 52.66% +0.23%
==========================================
Files 158 158
Lines 12108 12057 -51
==========================================
+ Hits 6348 6350 +2
+ Misses 5390 5337 -53
Partials 370 370 |
laurentsimon
temporarily deployed
to
integration-test
April 26, 2023 16:37
— with
GitHub Actions
Inactive
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
laurentsimon
force-pushed
the
feat/add-formats
branch
from
April 26, 2023 17:13
7fdedd6
to
4dc14a4
Compare
laurentsimon
temporarily deployed
to
integration-test
April 26, 2023 17:14
— with
GitHub Actions
Inactive
spencerschrock
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to what the difference between the three experimental formats will be.
I think its fine for the names to be a WIP if this is experimental.
laurentsimon
changed the title
✨ Add a new format for details
✨ [experimental] Add a new format for details
Apr 26, 2023
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
* update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> --------- Signed-off-by: laurentsimon <[email protected]> Signed-off-by: Avishay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new format
finding
to improve on the existingjson
format. This new format will be the same asjson
, but will display the details in a more structured format.Note that this is not the final "structured" format. This is a simpler version of it.
I have named the format "finding" because it's the underlying structure that will be used to populate it, but please suggest a better name.