Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use sha256 for release hashes #2172

Merged
merged 1 commit into from
Aug 18, 2022
Merged

✨ Use sha256 for release hashes #2172

merged 1 commit into from
Aug 18, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Aug 18, 2022

This updates the hash from sha512 to sha256 for release hashes. That's what's expected by the SLSA generator.
sha256 is enough for security

Use sha256 for goreleaser config

@laurentsimon laurentsimon temporarily deployed to integration-test August 18, 2022 21:10 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) August 18, 2022 21:12
@laurentsimon laurentsimon changed the title Use sha256 for release hashes ✨ Use sha256 for release hashes Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2172 (83bbd7e) into main (f7c0db7) will increase coverage by 2.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
+ Coverage   42.27%   44.67%   +2.40%     
==========================================
  Files          95       95              
  Lines        7868     7868              
==========================================
+ Hits         3326     3515     +189     
+ Misses       4282     4086     -196     
- Partials      260      267       +7     

@github-actions
Copy link

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@laurentsimon laurentsimon merged commit 2cbf5af into main Aug 18, 2022
@laurentsimon laurentsimon deleted the laurentsimon-patch-5 branch August 18, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants