Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix nil prt exception with empty repos #2011

Merged
merged 4 commits into from
Jun 29, 2022
Merged

🐛 Fix nil prt exception with empty repos #2011

merged 4 commits into from
Jun 29, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Jun 28, 2022 •
edited
Loading

Fix nil ptr exception with empty repos

Fix nil ptr exception with empty repos

closes #2010

@laurentsimon laurentsimon temporarily deployed to integration-test June 28, 2022 21:30 Inactive
@laurentsimon laurentsimon mentioned this pull request Jun 28, 2022
Closed
@laurentsimon laurentsimon enabled auto-merge (squash) June 28, 2022 21:32
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #2011 (375b2cf) into main (6a032a3) will increase coverage by 2.74%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
+ Coverage   50.44%   53.19%   +2.74%     
==========================================
  Files          88       87       -1     
  Lines        7237     7202      -35     
==========================================
+ Hits         3651     3831     +180     
+ Misses       3341     3119     -222     
- Partials      245      252       +7

@github-actions
Copy link

Integration tests success for
[abb85ab]
(https://github.com/ossf/scorecard/actions/runs/2579263432)

azeemshaikh38
azeemshaikh38 reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also add e2e tests for empty repo?

@laurentsimon
Copy link
Contributor Author

LGTM. Can we also add e2e tests for empty repo?

Done, thanks.

@laurentsimon laurentsimon temporarily deployed to integration-test June 29, 2022 14:24 Inactive
@github-actions
Copy link

Integration tests success for
[d575c26]
(https://github.com/ossf/scorecard/actions/runs/2583714688)

@github-actions
Copy link

Integration tests success for
[375b2cf]
(https://github.com/ossf/scorecard/actions/runs/2583722104)

azeemshaikh38
azeemshaikh38 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurentsimon laurentsimon merged commit 3957460 into ossf:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG running scorecard on a new repo with no commits results in a panic SIGSEGV
2 participants
@laurentsimon @azeemshaikh38