Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Move the cron job to internal package #1960

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Reduces exposed APIs by moving cron to internal package.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Removes `cron` package from exposed APIs.

@naveensrinivasan
Copy link
Member

This is should be a breaking change. Though technically no one should be using it. Let's still call it a breaking change.

@naveensrinivasan naveensrinivasan changed the title 🌱 Move the cron job to internal package ⚠️ Move the cron job to internal package May 25, 2022
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 25, 2022 21:33 Inactive
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1960 (fc9a703) into main (6a21afb) will increase coverage by 3.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
+ Coverage   50.79%   53.84%   +3.05%     
==========================================
  Files          83       83              
  Lines        6719     6719              
==========================================
+ Hits         3413     3618     +205     
+ Misses       3078     2867     -211     
- Partials      228      234       +6     

@github-actions
Copy link

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 25, 2022 21:59 Inactive
@github-actions
Copy link

@azeemshaikh38 azeemshaikh38 merged commit d1714a2 into main May 25, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/internal branch May 25, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants