Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Cron cleanup #1925

Merged
merged 1 commit into from
May 18, 2022
Merged

🌱 Cron cleanup #1925

merged 1 commit into from
May 18, 2022

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Follow up to #1920

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #1393

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 18, 2022 14:51 Inactive
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1925 (eb6b888) into main (fc7157e) will increase coverage by 3.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
+ Coverage   51.68%   54.70%   +3.02%     
==========================================
  Files          79       79              
  Lines        6782     6782              
==========================================
+ Hits         3505     3710     +205     
+ Misses       3046     2835     -211     
- Partials      231      237       +6     

@github-actions
Copy link

@azeemshaikh38 azeemshaikh38 merged commit 8fdb0e7 into main May 18, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/deprecate branch May 18, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: deprecate Pass/Fail model
3 participants