Code View + Code Search Public Beta Feedback #48301
Replies: 617 comments 674 replies
-
|
I've got some more feedback:
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for finding the redirect bug! Sorry about that, will fix ASAP. And good idea about linking to the search docs, will add that as well |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! Do you know if it might be possible to search commits of users for text / paths in the future? |
Beta Was this translation helpful? Give feedback.
-
|
Feel free to give feedback! I've got some more feedback:
Ashampoo_Snap_Donnerstag.23.Februar.2023_23h25m15s_005_.mp4=> It is working on the "Languages" tab, IF they are shown in the sidebar and not in the code search coming from the top, BUT there it is also adding the language to the same tab in addition to the new tab |
Beta Was this translation helpful? Give feedback.
-
|
Symbol search, YAY! (I mean I love that you can search for special characters like |
Beta Was this translation helpful? Give feedback.
-
|
Not sure it's related to this specific feature but on Firefox the tabs are overwhelmingly big(~20 characters) Though it's okay on Chrome(8 chars). |
Beta Was this translation helpful? Give feedback.
-
|
I am unable to repro this in Firefox. Mind if I ask you for some more info: Do you see the same behavior in Firefox without the beta enabled? Do you have any extensions enabled? |
Beta Was this translation helpful? Give feedback.
-
|
Its way too clunky... the search box appears over the page.... previously it was a dropdown within the search field - that was neater. Also, too much screen space is wasted in browsing code etc... the layout seems to copy projects but is not appropriate in such a boxed format. |
Beta Was this translation helpful? Give feedback.
-
|
how do you turn it off,i've disabled the beta button but it's still stuck .? |
Beta Was this translation helpful? Give feedback.
-
It's nice though because then you can actually see the full file paths most of the time, like the old search which was much wider. Indeed, I'd make the popup search box even wider than it is now because lots of paths wrap, which makes it harder to spot what you're looking for. |
Beta Was this translation helpful? Give feedback.
-
|
I don't like how you can't see the full file name in the file-explorer tree. There's no splitter, so you have to hover over each filename to see the whole name. |
Beta Was this translation helpful? Give feedback.
-
|
I also hate how the search covers the whole page...like come on guys the thing I'm wanting to search for 99% of the time is directly related to the code that the search modal just covered up. |
Beta Was this translation helpful? Give feedback.
-
Came to say this too. My colleague and I disabled it. Now, all of a sudden, it's stuck in this new mode whether you've disabled it or not... Please move the commit button back to the bottom. |
Beta Was this translation helpful? Give feedback.
-
|
The Code View's indention size has regressed and appears to be ignoring New Code View: Old Code View: Editorconfig file | Source file | Possibly related: #5098945 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting the issue. This is a regression, we should have a fix out soon! |
Beta Was this translation helpful? Give feedback.
-
|
A fix for this has been deployed and a follow fix is coming soon for honoring the editor config on edit as well. Let us know if you see any further issues. Thanks again for reporting! |
Beta Was this translation helpful? Give feedback.
-
|
I collapsed the file tree. How do I get it back? |
Beta Was this translation helpful? Give feedback.
-
|
Should be done with the same button that collapsed it, unless you're referring to something else? collapse.mp4Works a bit tricky for me though currently, have to click on a subfolder or file to get the tree view activated and then return to the branch. |
Beta Was this translation helpful? Give feedback.
-
|
Oh, I didn't notice the button when it was collapsed |
Beta Was this translation helpful? Give feedback.
-
|
Agree with this, it's not contextual, and I think it should stay in the same place (on the left). Right now, it's outside of the user's focus area 😓 |
Beta Was this translation helpful? Give feedback.
-
|
The team has debated over the placement of that open/close tree icon as well! We are working on bringing a better experience from the root overview page of the repository into the code/tree pages. Thanks for the feedback! |
Beta Was this translation helpful? Give feedback.
-
|
Yes this is not optimal solution. Coulndn't find it untill I read this post |
Beta Was this translation helpful? Give feedback.
-
|
File upload via drag and drop does not work in latest Safari. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting the issue, I was unable to repro with our latest shipped code. Are you still seeing the problem? |
Beta Was this translation helpful? Give feedback.
-
|
Big improvement. |
Beta Was this translation helpful? Give feedback.
-
|
Code view:
That being said, I don't use a lot of these sorts of features in IDEs either (the lag kills me) so maybe I'm just not used to it. Not sure if these are still bugs or got fixed:
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks so much for your very detailed feedback - this is incredibly useful for us in making a better experience! |
Beta Was this translation helpful? Give feedback.
-
|
+1 to
Trying to copy code from GH has become such a hassle with it deselecting text right before you press ctrl+c. |
Beta Was this translation helpful? Give feedback.
-
|
Really nice. Would love to relocate Symbol panel, from the right, to the bottom. It looks like it was designed with wide monitors in mind, but I work usually on narrow aspect ratios (4:3, 3:2, 1:1 - yes!, 10:16 - yes!, both at home, work and mobile). If I enabled something like side bars in my web browser (i.e. Tree Style Tab in Firefox), it gets even more narrow. It works great, but new github code view no so much. I am also more used to having it at the bottom from other projects and code searches, like Google Code Search. Example screen shot: Normal zoom level:
A bit of zoom:
For comparison here is google code search, at similar zoom level.
Density wise, new Code View, is not great. Long lines are cut, symbol names are sometimes cut, and there is not much reference given. Also default width of a tab, is way too big. Make it configurable, and make default to be 2em. |
Beta Was this translation helpful? Give feedback.
-
|
Tabs are customizable in 2 ways:
|
Beta Was this translation helpful? Give feedback.
-
|
Also this looks like a bug:
(see first line of the code) It behaves wonky depending if you scroll up or down. Also I really do not like this behavior at all. |
Beta Was this translation helpful? Give feedback.
-
|
The first line is a "sticky" line, which gives an indication of the scope that you're in (in this case, it tells you the name of the function you're reading) |
Beta Was this translation helpful? Give feedback.
-
|
This should work for all scopes then, such as |
Beta Was this translation helpful? Give feedback.
-
|
And I dislike intercepting Ctrl-F for showing popup for searching. It is incompatible with F3 and Shift-F3, and usually just slower than using browser search functionality. Yes, I know you can do Ctrl-F twice to bypass it. And I know that the popup search has scrollbar markers for matches. But in many web browser you also get it. Pressing Ctrl-F twice is not nice, due to habits of using normal search on other web pages. |
Beta Was this translation helpful? Give feedback.
-
It's still broken for me. I'm wondering if it's because I've got emacs bindings enabled, and the new ui uses a textarea which (when focused) is stealing keybindings like ctrl+f and ctrl+w (and e.g. moving the cursor around instead of searching). |
Beta Was this translation helpful? Give feedback.
-
|
What happened to this? It sounds like the keyboard hijacking was removed at some point, but now that this update is out of preview Ctrl+F and F3 both get stolen by the page again. Signing out doesn't get rid of it and there's not even an option to turn it off, just a passive-aggressive message telling me to try again if I was really serious about wanting to search the page normally. My browser's search function works exactly the way I want page search to work; there's nothing to improve, and literally any change a webpage could make will always be a regression. Apparently some people feel differently, but as far as I'm concerned it's NEVER okay to hijack browser-native keyboard shortcuts, and I've been upset for years that browsers even allow it. The current behavior is outright disrespectful to users and should have never been released, except as an explicitly opt-in feature. cc @colinwm |
Beta Was this translation helpful? Give feedback.
-
|
@DanH42 do you have the line-wrap seeing turned on? Or are you on blame? We are currently working on a way to support native Ctrl+F on both of those experiences but they are a work in progress. |
Beta Was this translation helpful? Give feedback.
-
|
@milemons I did turn on line wrapping when I was digging around for a way to stop the symbol sidebar from popping up all the time, and now that you mention it I see that turning it off also fixes page search. I really shouldn't have to choose between those two basic features when they're both default native browser behavior, but this is a preferable workaround to the alternative for now. I'm still not sure why it's so difficult to not override the browser's native functionality when word wrapping is enabled, especially considering it works just fine as long as I double-press Ctrl+F/F3 any time the page has focus. It certainly didn't used to be a limitation before GitHub decided that viewing a text file required a whole IDE in your browser. Some sort of a "Basic HTML" mode for GitHub (kind of like Gmail has) would also be a great solution here: I don't want any of these new features anyway, so a simple page that renders code with line numbers and syntax highlighting and basically nothing else would save me the trouble of having to figure out how to get rid of all the extra noise. And as others have mentioned, it would also be nice to be able to render a basic page without needing to run a bunch of Javascript -- that's just bad web development, no matter how many sites decide a blank white page is an acceptable thing for people to see when they don't want to (or aren't able to) execute 4MB of arbitrary code just to view a 4KB static file. Really, just spin up a copy of the codebase from 5 or 10 years ago at old.github.com and that would probably solve a lot of people's problems. |
Beta Was this translation helpful? Give feedback.
-
|
@milemons Do you really not see the problem with deploy first, fix later? What an awful response on your part. Thankfully this is less of an issue for me since I'm in the process of moving my stuff to Sourcehut… |
Beta Was this translation helpful? Give feedback.
-
|
Feedbacks:
|
Beta Was this translation helpful? Give feedback.
-
|
Just came here to mention the wasted screen space, glad you already made a point about that! It really makes a dent on a 13 inch screen! |
Beta Was this translation helpful? Give feedback.
-
|
Personally I like the meta info for every file. But I agree with you that clicking on anything brings up the symbols. This is 1) annoying and 2) breaks my browser's text selection which prevents me from copying the selected text.
It should be a I want to select text more than use the symbol explorer. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the usability feedback! We are still tweaking the symbol selection code a bit, have keyboard-cursor support coming soon, and fixes for better mobile usability, which should address some of your feedback here. Also, we are underway on fixing the transition from the repo overview page into the code and tree pages, so keep an eye out for those updated changes in the upcoming days/weeks. |
Beta Was this translation helpful? Give feedback.
-
|
Cool good to know!
I can see how they can be useful sometimes. The main issue I have with it is that I can't collapse it, and they follow you even as you scroll. There is no right answer as to what the default should be (give people more options? or just more screen estate?) but I wish there is a way to collapse it considering it's two rows of toolbars that's always overlaid on top of the content. The old UI has an overlay toolbar too but it was only one row, so I guess the extra row was the straw that broke the camel's back for me. |
Beta Was this translation helpful? Give feedback.
-
|
Same opinion as for the "Symbols panel": Useful, BUT if it was not activated by the user, then clicking in the code should not open it. Otherwise, every time you click/navigate in the code file, there is an unwanted "pop-up" that opens, and that also updates/changes with every others click in the file, which is very unpleasant. If I haven't opened the "Symbols panel", it's because I don't want to use it. |
Beta Was this translation helpful? Give feedback.
-
|
The new code view layout is now distinct from the root page of the repo (where the |
Beta Was this translation helpful? Give feedback.
-
|
Agreed! The team is working on a design here. There are some extra considerations we wanted to iron out before using the same tree as the blob and tree pages. We should have changes here coming soon! I don't want to share a date just yet. |
Beta Was this translation helpful? Give feedback.
-
The product is really amazing but I didn’t understand how does it sort the ranking of who’s repository would be above. |
Beta Was this translation helpful? Give feedback.
-
|
Mobile code viewer is too laggy in horizontal scrolling: 2_5221931803819912022.mp4 |
Beta Was this translation helpful? Give feedback.
-
|
Download button doesn't work |
Beta Was this translation helpful? Give feedback.
-
|
Would you be able to provide a link to the file where the download button doesn't work? Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
Accessibility concern: This is Firefox 114.0.2 on macOS Ventura 13.4.1 with the following zoom setting: |
Beta Was this translation helpful? Give feedback.
-
Haha, good that I solved your problem first before reading that hypocritical bs, otherwise I wouldn't have helped you. |
Beta Was this translation helpful? Give feedback.
-
|
I just tried on a Windows machine instead of Mac and even tried a different font. It does not work. I see that it works in other Chromium-based browsers -- the feature is called "Page zoom" there, btw -- and that's great. I didn't report it broken for those other browsers, and Firefox is listed as a supported browser by GitHub. |
Beta Was this translation helpful? Give feedback.
-
|
@smarts I already explained how to circumvent your problem and that this is not the right place to report your issue since it is not GitHub's fault or bug. Please learn how to think and stop wasting people's time.
Yes, it does. I could reproduce your issue and easily circumvent it – took me 20 seconds to figure out how. This kind of behavior has nothing to do with the OS. If you had any decent problem solving skills, you could've easily avoided posting your issue here, but even if you did post it, you would've simply apologized for your hypocritical nonsense after reading my replies, fixed the setting, and moved on. I don't know whether you're insincere or you really tried to 1. uncheck that box and 2. reload the page, but somehow failed. But I don't care, what I wrote is correct regardless of your incompetence.
Exactly, which is the same as in Firefox when you disable the "Zoom text only" feature – which does not exist in Chrome. |
Beta Was this translation helpful? Give feedback.
-
You say this while flooding the mailboxes of all the people that watch this page with insults.
The initial comment itself already clearly stated “when text zoom is enabled”, si I’m not sure there was any need for these extra investigations. And if by “help” you mean “yelling at people”, I suspect they will be better off without that anyway.
I can’t tell anything for sure there, but if that feature works on 99% of websites, there’s a good chance that there is something GitHub can do to make it work there as well (and I got the impression that they tend to listen to users when accessibility features are concerned). But I agree that this may be a bit wonky – I had to disable something similar on my mobile the other day for different reasons. |
Beta Was this translation helpful? Give feedback.
-
I
In case it was clear that only some special non-standard settings are messing with the page, it should've also been clear that this was off-topic from the beginning. One can mess up every website's appearance when just using the wrong settings to display them.
There was a lot of criticism on GitHub's stupid design decision for their scripted code view, but they showed no signs of being willing to rework it entirely in order to avoid the hundreds of issues that come with it. They mostly ignored this whole disaster to begin with. I mean, handling such a non-issue differently because it is for AcCeSsIbIlItY would fit their stupid agenda towards political correctness, but it makes no sense whatsoever to now rework the code view entirely because some people want to use non-standard settings which mess up page dimensions by definition. Especially when they can simply use zooming instead of text-only enlargement! |
Beta Was this translation helpful? Give feedback.
-
|
For the love of god is there any way to disable this nonsense? The blog post talks about how reading code is a "sometimes chaotic process" and this new UI seems to only amp up the chaos. I don't want doodads, popups, new panes, "smart" analytics, or whatever whiz bang feature seems to justify keeping on so many UI monkeys. I want to view the freaking code. Remember when Balmer did his "developers, developers, developers" chant? Try this one on for size: "code, code, code!". When I try to view a folder I don't want a directory tree taking up space. When I try to select text I don't want a whiz bang doodad off to the right popping up mysteriously offering to list symbols. Chaos aside, do you know the other reason I don't want a list of symbols (or whatever) popping up? Github does an atrocious job of indexing source, and I've already learned that the search is so broken as to be useless (and otherwise best avoided). I get that there were major performance issues before, but come on don't make the changes so intrusive. Let the performance speak for itself. You know what this does motivate me to do? Shallow clones so I can leverage a more usable editor locally without all the cloudy, artificial machine learning buzzword compliance that seems to be leaking into Github. P.S. There's even a broken (stuck on) tooltip that's rubbing salt into the wound. P.P.S. As I type this I'm watching the UI widgets below (a.k.a. "Attach files by dragging…" bounce up and down. This is one update that's best left for the circular file. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
Can you provide more context as to what the problem is? |
Beta Was this translation helpful? Give feedback.
-
|
@AdamShwert Well the problem seems to be that you scroll the comment input box out of view when "quote reply" is selected (bravo on that one). |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
I find it simultaneously funny and sad that this feature is in proprietary development and total crap, but aimed at a site meant to encourage open source development. |
Beta Was this translation helpful? Give feedback.
-
|
Javascript is now required to just view file, and there is no way to opt-out. WHY! WHY! WHY! |
Beta Was this translation helpful? Give feedback.
-
|
Note that Jira also has a |
Beta Was this translation helpful? Give feedback.
-
|
Which page are you on where this is happening? |
Beta Was this translation helpful? Give feedback.
-
|
Do you all not understand that this "new" search functionality is simply not ready for prime time? Who puts untested code into production like this? Do you all have anyone on your staff that understands what a software development lifecycle is? |
Beta Was this translation helpful? Give feedback.
-
@AdamShwert |
Beta Was this translation helpful? Give feedback.
-
|
When you go to https://github.github.io/hotkey/examples/hotkey_mapper.html and press the |
Beta Was this translation helpful? Give feedback.
-
|
@AdamShwert |
Beta Was this translation helpful? Give feedback.
-
|
A couple of bugs with Jump to line feature while on git-blame mode I've been experiencing on Firefox. First: using the enter key to go-to line will reload the page at the specified line but on code view (git-blame is lost).
Result: Expected: Second: using the 'Go' button on the go-to line modal scrolls the view to the right line but the URL does not update and the line is not highlighted.
Result:
|
Beta Was this translation helpful? Give feedback.
-
|
Revert this... give us sort option back! |
Beta Was this translation helpful? Give feedback.
-
|
The updates lately are rendering GitHub unusable. Who pushed this code to production and why... :( |
Beta Was this translation helpful? Give feedback.
-
|
please reverse this change already |
Beta Was this translation helpful? Give feedback.
-
|
Hey GitHub team , Recently, I have been noticed that the GitHub having an issue in counting the number of contributions
my new commits are being recorded on 25th July 2023 and right now when I'm posting this comment its 26th July 2023 00:33 (UTC +5:30) |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
it works but it's slow! |
Beta Was this translation helpful? Give feedback.
-
|
but something is wrong |
Beta Was this translation helpful? Give feedback.
-
|
How can I help? |
Beta Was this translation helpful? Give feedback.
-
|
any update |
Beta Was this translation helpful? Give feedback.
-
This Discussion has been closed because it's outdated. To provide feedback on code search and code view, please click here.
Thanks for trying GitHub’s new code search and code view - the most powerful way to search and navigate the world’s code. Our team is excited to share this feature with you today in beta.
Now anyone can access the new search and code viewing experience using this link, or via the feature preview menu. To access the feature preview menu, click your avatar at the top-right of a GitHub page and select Feature preview. Then select the beta and click the Enable button.
We are dedicated to making GitHub the best code navigation experience on the web. If you encounter any issues or have suggestions on how we can improve the experience, please share below. We will review all feedback!
Beta Was this translation helpful? Give feedback.
All reactions