Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auth breaking changes #5696

Merged
merged 3 commits into from
Oct 13, 2022
Merged

feat: auth breaking changes #5696

merged 3 commits into from
Oct 13, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Oct 13, 2022 •
edited
Loading

  • deps: @npmcli/[email protected]
  • feat: explicitly validate config within the cli
  • feat: introduce the npm config fix command

Closes #5653

nlf added 3 commits October 12, 2022 19:12
@nlf @lukekarrys
deps: @npmcli/[email protected]
0e59fda
@nlf @lukekarrys
feat: explicitly validate config within the cli
5fa1f79 
BREAKING CHANGE: the presence of auth related settings that are not scoped to a specific registry found in a config file is no longer supported and will throw errors
@nlf @lukekarrys
feat: introduce the npm config fix command
5c1315e
@lukekarrys lukekarrys requested a review from a team as a code owner October 13, 2022 02:18
@lukekarrys
Copy link
Contributor Author

This is the same as #5653 except rebased on to latest. I opened it as a second PR since it is @nlf's work and didn't want to overwrite history in case I messed up the rebase. The only conflicts were with #5309.

@fritzy fritzy merged commit a09e19d into latest Oct 13, 2022
@fritzy fritzy deleted the lk/auth-breaking-change-rebase branch October 13, 2022 15:46
@github-actions github-actions bot mentioned this pull request Oct 13, 2022
Merged
@lukekarrys lukekarrys mentioned this pull request Nov 1, 2022
Closed
This was referenced Nov 5, 2022
Closed
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 16, 2022
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 30, 2022
Merged
@jshields-squarespace jshields-squarespace mentioned this pull request Dec 20, 2022
Open
@sjd78 sjd78 mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy fritzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @fritzy @nlf