Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to CONTRIBUTING.md that make pretty is required for test updates. #4045

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Add to CONTRIBUTING.md that make pretty is required for test updates. #4045

merged 1 commit into from
Jun 8, 2023

Conversation

gregmarr
Copy link
Contributor

@gregmarr gregmarr commented Jun 3, 2023

Add to CONTRIBUTING.md that make pretty is required for test updates, as not doing so will result in a failure in the amalgamation check.

Pull request checklist

  • Changes are described in the pull request, or an existing issue is referenced.
  • [n/a] The test suite compiles and runs without error.
  • [n/a] Code coverage is 100%. Test cases can be added by editing the test suite.
  • [n/a] The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

@gregmarr gregmarr requested a review from nlohmann as a code owner June 3, 2023 17:18
@github-actions github-actions bot added the S label Jun 3, 2023
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 3128fae on gregmarr:patch-1 into a0c1318 on nlohmann:develop.

@nlohmann
Copy link
Owner

nlohmann commented Jun 4, 2023

Oof, Clang-Tidy again has some complaints... I'll check before merging this.

@gregmarr
Copy link
Contributor Author

gregmarr commented Jun 5, 2023

The clang-tidy complaints are in files not touched by this PR.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Jun 8, 2023
nlohmann
nlohmann approved these changes Jun 8, 2023
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit 254395e into nlohmann:develop Jun 8, 2023
@nlohmann
Copy link
Owner

nlohmann commented Jun 8, 2023

Thanks a lot!

@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
documentation S
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmarr @coveralls @nlohmann