Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CMake minimum version #4076

Closed
2 tasks done
jmigual opened this issue Jul 19, 2023 · 2 comments
Closed
2 tasks done

Upgrade CMake minimum version #4076

jmigual opened this issue Jul 19, 2023 · 2 comments
Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation

Comments

@jmigual
Copy link

jmigual commented Jul 19, 2023

Description

Right now this project requires a minimum CMake version of 3.1. Since the new release of CMake (3.27), versions < 3.5 are considered deprecated and will be removed in the future.

This is why we should increase the CMake minimum version. I suggest 3.16 as the new minimum as this is the one that ships with Ubuntu 20.04.

Reproduction steps

Configure the project with CMake 3.27 and you'll get the following error:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.

Expected vs. actual results

No cmake warning shows up.

Minimal code example

No response

Error messages

No response

Compiler and operating system

MSVC on Windows

Library version

master

Validation

@Nauroze
Copy link

Nauroze commented Jul 23, 2023

Would like to fix this.

Nauroze added a commit to Nauroze/json that referenced this issue Jul 23, 2023
Nauroze added a commit to Nauroze/json that referenced this issue Jul 24, 2023
Nauroze added a commit to Nauroze/json that referenced this issue Jul 24, 2023
Nauroze added a commit to Nauroze/json that referenced this issue Jul 24, 2023
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Sep 25, 2023
@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 25, 2023
@nlohmann
Copy link
Owner

Fixed with #4112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants