Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain upgrade to nightly-2023-11-01 failed #2848

Closed
github-actions bot opened this issue Nov 1, 2023 · 0 comments · Fixed by #2858
Closed

Toolchain upgrade to nightly-2023-11-01 failed #2848

github-actions bot opened this issue Nov 1, 2023 · 0 comments · Fixed by #2858

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Updating Rust toolchain from nightly-2023-10-31 to nightly-2023-11-01 requires source changes.
The failed automated run can be found here.
Please review the changes at https://github.com/rust-lang/rust from rust-lang/rust@31bc7e2 up to rust-lang/rust@9d83ac2. The log for this commit range is:
rust-lang/rust@9d83ac2179 Auto merge of #117462 - weihanglo:update-cargo, r=weihanglo
rust-lang/rust@7ea6977649 Update cargo
rust-lang/rust@50be229640 Auto merge of #117450 - oli-obk:rustdoc_verify, r=estebank
rust-lang/rust@d7d9f15be2 Auto merge of #117407 - compiler-errors:derive-clone, r=oli-obk
rust-lang/rust@4512f211ae Accept less invalid Rust in rustdoc
rust-lang/rust@8b4fa0f8b5 Use derivative for Hash
rust-lang/rust@8eb932dcf0 Use derivative for PartialOrd/ord
rust-lang/rust@de83057ac4 Use derivative for Clone
rust-lang/rust@045f158d7b Auto merge of #117444 - matthiaskrgr:rollup-43s0spc, r=matthiaskrgr
rust-lang/rust@f623530742 Rollup merge of #117438 - cjgillot:deterministic-error, r=oli-obk
rust-lang/rust@793776f39d Rollup merge of #117421 - Zalathar:error, r=oli-obk,Swatinem
rust-lang/rust@8daa317a4b Rollup merge of #117416 - compiler-errors:tait-in-bad-body, r=oli-obk
rust-lang/rust@7035c3d718 Rollup merge of #116712 - estebank:issue-116252, r=petrochenkov
rust-lang/rust@d0833c4b66 Rollup merge of #116267 - oli-obk:simd_cleanups, r=petrochenkov
rust-lang/rust@f8372df631 Merge simd size and type extraction into checking whether a type is simd, as these always go together.
rust-lang/rust@9a49ef38c7 Simplify all require_simd invocations by moving all of the shared invocation arguments into the macro
rust-lang/rust@7c673db195 don't use the moral equivalent of assert!(false, "foo")
rust-lang/rust@6d956a228b coverage: Replace impossible coverage::Error with assertions
rust-lang/rust@8ef67d0f01 coverage: Promote some debug-only checks to always run
rust-lang/rust@5b7cc9d704 Do not ICE on constant evaluation failure in GVN.
rust-lang/rust@22b27120b9 Auto merge of #117377 - dtolnay:deprecatedsince, r=cjgillot
rust-lang/rust@ffb7ed9fa4 Auto merge of #117419 - compiler-errors:gen, r=oli-obk
rust-lang/rust@650991d62c Auto merge of #117363 - saethlin:cross-crate-inline-when-inline, r=tmiasko
rust-lang/rust@8b8906b264 Add method for checking if deprecation is a rustc version
rust-lang/rust@dccf10e989 Descriptive variant name deprecation versions outside the standard library
rust-lang/rust@add09e66f2 Some more coroutine renamings
rust-lang/rust@e8868af75b Represent absence of 'since' attribute as a variant of DeprecatedSince
rust-lang/rust@c52367276d Preserve deprecation attribute even if 'since' version is missing
rust-lang/rust@a395214a3a Auto merge of #116405 - estebank:issue-103155, r=davidtwco
rust-lang/rust@b106167673 Add a DeprecatedSince::Err variant for versions that fail to parse
rust-lang/rust@b8a8ba9c91 Sort errors
rust-lang/rust@8c5577283c Add test
rust-lang/rust@17a6ae2df3 Detect object safety errors when assoc type is missing
rust-lang/rust@48491c182b Also consider TAIT to be uncomputable if the MIR body is tainted
rust-lang/rust@1e10fe9eb6 Move deprecation_in_effect to inherent method on Deprecation
rust-lang/rust@8afb40b3a8 Delete unused InvalidDeprecationVersion diagnostic
rust-lang/rust@2fe7d17bd9 Store version of deprecated attribute in structured form
rust-lang/rust@5c7cf83739 Fill in syntactically valid deprecation version in tests
rust-lang/rust@1e5b2da94b Rename Since -> StableSince in preparation for a DeprecatedSince
rust-lang/rust@50ca5ef07f When encountering unclosed delimiters during parsing, check for diff markers
rust-lang/rust@e53b18f033 Enable cross-crate-inlining when MIR inlining is enabled

zhassan-aws added a commit that referenced this issue Nov 6, 2023
Update to the latest Rust toolchain (2023-11-06).

The relevant changes are:
- rust-lang/rust#117507: this required changing
the import of `Span` from `rustc_span::source_map::Span` to
`rustc_span::Span`.
- rust-lang/rust#114208: this changed the data
field for the `OffsetOf` variant of `NullOp` from `List<FieldIdx>` to
`List<(VariantIdx, FieldIdx)>`, which required updating the relevant
code in `rvalue.rs`.
- rust-lang/rust#115626: the unchecked shift
operators have been separated from the `unchecked_math` feature, so this
required changing the feature annotation in
`tests/ui/should-panic-attribute/unexpected-failures/test.rs`
- Some rustc change (not sure which one) result in a line in
`tests/coverage/unreachable/variant/main.rs` getting optimized out. To
maintain what this test is testing, I changed the `match` to make it a
bit less-prone to optimization.
- A change in `cargo` (rust-lang/cargo#12779)
resulted in an update to Kani's workspace `Cargo.toml` when `cargo add`
is executed inside `tests/script-based-pre/build-cache-bin`. This is
apparently intended behavior, so I had to make the `exclude` in the
`Cargo.toml` more specific to make sure this doesn't happen (I tried
using a glob, but that didn't work, apparently because of
rust-lang/cargo#6009.

Resolves #2848 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants