Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document elastic indexed Jobs #39999

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Document elastic indexed Jobs #39999

merged 1 commit into from
Apr 4, 2023

Conversation

danielvegamyhre
Copy link
Member

@danielvegamyhre danielvegamyhre commented Mar 14, 2023 •
edited
Loading

Document Elastic Indexed Jobs which were added in kubernetes/kubernetes#115236

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 14, 2023
@danielvegamyhre danielvegamyhre mentioned this pull request Mar 14, 2023
Closed
@sftim
Copy link
Contributor

sftim commented Mar 14, 2023

/retitle [WIP] Document elastic indexed Jobs

@k8s-ci-robot k8s-ci-robot changed the title Elastic Indexed Job Docs [WIP] Document elastic indexed Jobs Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@sftim
Copy link
Contributor

sftim commented Mar 14, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 14, 2023
@netlify
Copy link

netlify bot commented Mar 14, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 86f14f9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6418c5413fd8f70008b71c74
😎 Deploy Preview https://deploy-preview-39999--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielvegamyhre danielvegamyhre mentioned this pull request Mar 14, 2023
Merged
@ahg-g ahg-g mentioned this pull request Mar 14, 2023
Closed
8 tasks
@sftim
Copy link
Contributor

sftim commented Mar 16, 2023

Should this PR target dev-1.27?

@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch from 97c10d5 to 8c6b582 Compare March 17, 2023 16:12
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2023
@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch from 8c6b582 to ee55517 Compare March 17, 2023 16:15
@danielvegamyhre
Copy link
Member Author

@alculquicondor this is ready for review

@danielvegamyhre danielvegamyhre changed the title [WIP] Document elastic indexed Jobs Document elastic indexed Jobs Mar 17, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2023
@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch 2 times, most recently from 41741ad to 3bd7a44 Compare March 17, 2023 17:16
soltysh
soltysh reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aldo's comments still apply

content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
@danielvegamyhre
Copy link
Member Author

@alculquicondor @soltysh Thanks for reviewing, I've addressed your comments and this is ready for another look

@danielvegamyhre danielvegamyhre changed the base branch from main to dev-1.27 March 31, 2023 21:14
@danielvegamyhre
Copy link
Member Author

/milestone 1.27

@danielvegamyhre
Copy link
Member Author

@tengqm I had clicked "Commit Suggestion" on one comment, but hadn't addressed the other comments yet. I have now addressed all the comments and this is ready for another look.

@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch from f791902 to cf9f069 Compare April 3, 2023 16:00
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 3, 2023
@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch from 80b4095 to 419ccfc Compare April 3, 2023 16:06
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 3, 2023
@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch 2 times, most recently from 1050b17 to cc4e0f4 Compare April 3, 2023 16:21
@danielvegamyhre
Copy link
Member Author

@alculquicondor @tengqm Thanks for the reviews, I have addressed your comments and this is ready for another look.

@mickeyboxell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 201dafb4efd496951b2e5476028f984d8f8d5f63

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@danielvegamyhre danielvegamyhre force-pushed the elastic-indexed-job-docs branch from e2e487a to 618a942 Compare April 4, 2023 01:12
@LukeMwila
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e5229b17791bafbd2848b4c1721b8f23ef77a256

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit d59af75 into kubernetes:dev-1.27 Apr 4, 2023
@danielvegamyhre danielvegamyhre deleted the elastic-indexed-job-docs branch April 4, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@tengqm tengqm tengqm left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@soltysh soltysh soltysh left review comments

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

Assignees

@mickeyboxell mickeyboxell

@LukeMwila LukeMwila

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
10 participants
@danielvegamyhre @sftim @k8s-ci-robot @tengqm @mickeyboxell @LukeMwila @reylejano @soltysh @alculquicondor @divya-mohan0209