-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify cosign
signatures of distroless base images
#2016
Conversation
Signed-off-by: Jake Sanders <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @hasheddan @puerco |
/test pull-release-image-go-runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
- go-runner:v2.3.1-go1.16.3-buster.1 - go-runner:v2.3.1-go1.15.11-buster.1 Signed-off-by: Stephen Augustus <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dekkagaijin, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4e89b42
to
4a438b5
Compare
(needs re-/lgtm; had to update the image revision numbers) |
/lgtm |
/test pull-release-image-go-runner |
Thanks, @justaugustus 🎉🦜🎉 |
Does cosign verify that the signer of a container has been authorized by the original supplier of the container to sign on their behalf? How do you verify that the signer and original supplier form a trusted relationship? |
Sopalsuemae นายซอปาลซือแม |
@rjb4standards That's a complicated question, but in this specific case k8s is pinning the trusted public key that has been checked in to the distroless repo: https://github.com/GoogleContainerTools/distroless/blob/main/cosign.pub |
What type of PR is this?
/kind feature
/area dependency security
What this PR does / why we need it:
From @dekkagaijin in #2011:
This'll ensure that the
distroless
base images were built on trusted infrastructureWhich issue(s) this PR fixes:
Special notes for your reviewer:
I did a git oops when pushing updates to @dekkagaijin's branch, which accidentally closed #2011.
Does this PR introduce a user-facing change?