Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to do full comparison to prevent time based guessing of the private key #12

Closed
jasongoodwin opened this issue Mar 23, 2015 · 2 comments · Fixed by #36
Closed

add option to do full comparison to prevent time based guessing of the private key #12

jasongoodwin opened this issue Mar 23, 2015 · 2 comments · Fixed by #36

Comments

@jasongoodwin
Copy link
Owner

Tim McClean flagged that users may be able to guess how correct their guesses are by measuring time of response.
Seems this might be difficult to actually exploit but we can add some non-blocking delays or otherwise do a full comparison.
@anfedorov
Copy link
Contributor

anfedorov commented Nov 2, 2017 •
edited
Loading

Why do you think this is difficult to exploit? afaik, this is exploit level "undergrad security 101 homework" — you time the responses and after enough of a distribution emerges you go to the next byte.

@anfedorov
Copy link
Contributor

More info here and here. PR inc.

anfedorov added a commit to merit/authentikat-jwt that referenced this issue Nov 5, 2017
@anfedorov
Use constant-time string comparison for sigs
2d2fa0d 
Fixed jasongoodwin#12
@anfedorov anfedorov mentioned this issue Nov 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use constant-time string comparison for sigs merit/authentikat-jwt
2 participants
@anfedorov @jasongoodwin