You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today I learned about the cake rule doc:test which builds the browser tests from the main tests (similar to build:browser but for the tests). This PR ensures that those tests are up-to-date before CI can succeed, similar to the other build operations we do.
As a side note, I find the name doc:test rather confusing, as it's about building tests not documenting or running them. But that's less important.
Today I learned about the cake rule `doc:test` which builds the browser tests from the main tests (similar to `build:browser` but for the tests). This PR ensures that those tests are up-to-date before CI can succeed, similar to the other build operations we do.
As a side note, I find the name `doc:test` rather confusing, as it's about building tests not documenting or running them. But that's less important.
It turns out the issue wasn't that the output wasn't updated, it's that the order that the tests were combined was inconsistent, dependent on the filesystem. Sorting the directory seems to produce the original results; tests now pass. I'm guessing that some file systems automatically sort listdir, but Windows didn't, and apparently CI (ubuntu I think?) didn't.
The cake doc:test script concatenates a bunch of files into one file. If the file order is inconsistent, so are the results. The result needs to be consistent for CI to check that it was built properly. (It will also make for smaller diffs, if they get built on a nonalphabetical file system.)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I learned about the cake rule
doc:testwhich builds the browser tests from the main tests (similar tobuild:browserbut for the tests). This PR ensures that those tests are up-to-date before CI can succeed, similar to the other build operations we do.As a side note, I find the name
doc:testrather confusing, as it's about building tests not documenting or running them. But that's less important.