-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make origin offset immutable #612
Conversation
This is the same PR as #589, but due to a dumb branch deletion on my part and a dumber restriction on GitHub's part, that PR is now un-re-openable forevermore. So y'all get this one now instead. 😝 FWIW this addresses the feedback given in the previous PR, primarily moving the offset reference space creation mechanism from a constructor to a method, which definitely feels cleaner. PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on the design. A few minor questions
540d77f
to
10a60a0
Compare
Addressed the feedback about the unnecessary new text, and the other two comments appear to be potential non-issues? Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #580. Changes originOffset to be immutable and establish that the way that the originOffset changes is by constructing a new reference space with the base space and an additional offset to apply on top of it. This should hopefully solve several timing issues related to changing the originOffset mid-frame.
10a60a0
to
917d088
Compare
Fixes #580. Changes originOffset to be immutable and establish that the
way that the originOffset changes is by creating a new reference
space with the
getOffsetReferenceSpace()
method of the base space.This should hopefully solve several timing issues related to changing the
originOffset mid-frame.