Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use isinstance() per E721, unpin flake8 #1659

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: use isinstance() per E721, unpin flake8 #1659

merged 3 commits into from
Sep 18, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Sep 16, 2023

  • Fixes lint error following E721
  • Unpins flake8==6.0.0 because error is resolved

Fixes #1635 🦕

@Linchin Linchin requested review from a team as code owners September 16, 2023 01:03
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 16, 2023
@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 18, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2023
chalmerlowe
chalmerlowe approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 54a7769 into googleapis:main Sep 18, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Sep 18, 2023
Merged
@Linchin Linchin deleted the lint-error branch September 18, 2023 22:19
@Linchin Linchin mentioned this pull request Sep 19, 2023
Merged
This was referenced Oct 10, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@prash-mi prash-mi Awaiting requested review from prash-mi prash-mi is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint session fails with flake8==6.1.0
3 participants
@Linchin @chalmerlowe @yoshi-kokoro