docs: regenerate the samples/README.md #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 97.92% 97.94% +0.01%
==========================================
Files 9 9
Lines 869 874 +5
Branches 99 99
==========================================
+ Hits 851 856 +5
Misses 9 9
Partials 9 9
Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Mar 28, 2019
JustinBeckwith
approved these changes
Mar 28, 2019
stephenplusplus
previously requested changes
Apr 2, 2019
samples/README.md
Outdated
|
|
||
| ## Before you begin | ||
|
|
||
| Before running the samples, make sure you've followed the steps in the | ||
| [Before you begin section](../README.md#before-you-begin) of the client | ||
| [Using the client library](https://github.com/googleapis/nodejs-storage#using-the-client-library) of the client |
There was a problem hiding this comment.
This doesn't read very well. Maybe it should be quoted around the link, and we can probably remove all the "client library" phrasing. Maybe "...make sure you've followed these steps."
JustinBeckwith
approved these changes
Apr 2, 2019
This was referenced Apr 2, 2019
|
@bcoe can we land this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: googleapis/google-cloud-node#2868 we can now magically auto-generate both README.md and samples/README.md (this will become all the more powerful with discussions around auto-generating
.repo-metadata.json(CC: @busunkim96, @jmdobry).This pull request:
samples/README.md(this file is a slight simplification, no longer rendering the yargs CLI output, which is being removed from newer samples any ways).generate-scaffoldingfrom thepackage.json(as it's now not used by anything).Related: googleapis/synthtool#214