fix: getSigned(Policy|Url) throws if expiration is invalid Date #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenplusplus I get that it's likely unrelated, but can you investigate the grpc-js system test failures? It's likely a race condition with running the system tests twice at the same time. Using this as a good opportunity to squash those bugs out. |
JustinBeckwith
approved these changes
Feb 22, 2019
|
WOW!!! Hats off to you guys. This was really quick. I used to work for Google Customer Service a few years ago and the response time was significantly bigger than this. What a change towards customers!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613
If the user provides an invalid Date to
file.getSignedPolicy()orfile.getSignedUrl(), we will now throw.