Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): move jsdoc away from interface #565

Merged
merged 3 commits into from
Dec 28, 2018
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Dec 27, 2018

JSDoc comments above interfaces are not preserved when compiling to
TypeScript, this is casuing current docs to have missing types.

See https://cloud.google.com/nodejs/docs/reference/storage/2.3.x/File#copy
The options parameter to File#copy is missing a link to type CopyOptions.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2018
@jkwlui jkwlui requested a review from a team December 27, 2018 23:20
@jkwlui jkwlui self-assigned this Dec 28, 2018
@JustinBeckwith JustinBeckwith merged commit 4212cce into master Dec 28, 2018
@jkwlui jkwlui deleted the fix-file-docs branch December 28, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants