fix(ts): Update bucket options types

[bittlingmayer]

Fixes #346

• Tests and linter pass

I did not check.

• Code coverage does not decrease (if any source code was changed)

I did not check.

• Appropriate docs were updated (if necessary)

I have not read all the docs, but the comments already suggested that this was possible, now the code is in harmony with them.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[bittlingmayer]

I signed it.

[googlebot]

CLAs look good, thanks!

[JustinBeckwith]

👋 thanks for the PR! It looks like we needed that property :)

> @google-cloud/[email protected] compile /home/node/project
> tsc -p .

system-test/storage.ts:2124:50 - error TS2345: Argument of type '{ location: string; }' is not assignable to parameter of type 'BucketOptions'.
  Object literal may only specify known properties, and 'location' does not exist in type 'BucketOptions'.

2124         bucket = storage.bucket(generateName(), {location: BUCKET_LOCATION});

Can you try to run npm run compile and npm test, fix the issues, and submit again?

[JustinBeckwith]

I think we needed that location field there :)

[bittlingmayer]

@JustinBeckwith I think the test is wrong, see https://cloud.google.com/nodejs/docs/reference/storage/2.0.x/Storage and comments in #346.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[stephenplusplus]

@JustinBeckwith CLA help?

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)