Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify timestamps in Spanner Graph java sample code #3289

Closed
bharadwajvr opened this issue Aug 21, 2024 · 0 comments · Fixed by #3295
Closed

Simplify timestamps in Spanner Graph java sample code #3289

bharadwajvr opened this issue Aug 21, 2024 · 0 comments · Fixed by #3295
Assignees
@rahul2393
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples.

Comments

@bharadwajvr
Copy link
Contributor

There are commit timestamps used in the Spanner Graph java sample code that requires corresponding feature enablement in the schema. This distracts from the core features that the sample seeks to illustrate. Changing that will simplify the samples.
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Aug 21, 2024
This was referenced Aug 21, 2024
Closed
Merged
lqiu96 pushed a commit that referenced this issue Sep 10, 2024
@bharadwajvr @lqiu96
docs: change the example timestamps in Spanner Graph java sample code (…
ffe95ea 
…#3295)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue]-
- [x] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #3289 ☕️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
2 participants
@rahul2393 @bharadwajvr